-
Notifications
You must be signed in to change notification settings - Fork 90
Add tests to custom search with matching_strategy param #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
44b731b
to
bf974e6
Compare
816a1d4
to
530b630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new tests look great. FYI, when you make an error on the base branch, you can push an empty commit to force GitHub to re-execute on the correct branches. (except if you have to push a new commit it)
530b630
to
72d365c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @brunoocasali 🔥
523: Update version for the next release (v0.22.0) r=alallema a=brunoocasali This version makes this package compatible with Meilisearch v0.29.0 🎉 Check out the changelog of [Meilisearch v0.29.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.29.0) for more information on the changes. ## 🚀 Enhancements - Ensure support to the new search query parameter `matchingStrategy` (#522) `@brunoocasali` - Ensure support to keys with wildcarded actions. - `actions` field during key creation now accepts wildcards on actions. For example, `indexes.*` provides rights to `indexes.create`, `indexes.get`,`indexes.delete`, `indexes.delete`, and `indexes.update`. (#521) `@brunoocasali` ##⚠️ Breaking Changes This breaking change *__may not affect you__*, but in any case, you should check your search queries if you want to keep the same behavior from `v0.28`. - The `NOT` filter keyword does not have an implicitly `EXIST` operator anymore. Check out for more information: meilisearch/meilisearch#2486 Co-authored-by: Bruno Casali <[email protected]> Co-authored-by: alallema <[email protected]> Co-authored-by: Amélie <[email protected]>
Ensure the support of
matching_strategy
query parameter.