Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add tests to custom search with matching_strategy param #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

brunoocasali
Copy link
Member

Ensure the support of matching_strategy query parameter.

@brunoocasali brunoocasali added the enhancement New feature or request label Sep 2, 2022
@brunoocasali brunoocasali changed the base branch from add-tests-to-global-keys to fix-test-after-update September 2, 2022 22:30
@brunoocasali brunoocasali changed the base branch from fix-test-after-update to bump-meilisearch-v0.29.0 September 2, 2022 22:39
@brunoocasali brunoocasali changed the base branch from bump-meilisearch-v0.29.0 to fix-test-after-update September 2, 2022 22:39
@brunoocasali
Copy link
Member Author

@alallema, the CI was affected because I created the PR pointing to the wrong place. As soon you can merge the #520 you'll see this passing :)

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tests look great. FYI, when you make an error on the base branch, you can push an empty commit to force GitHub to re-execute on the correct branches. (except if you have to push a new commit it)

Base automatically changed from fix-test-after-update to bump-meilisearch-v0.29.0 September 5, 2022 14:18
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @brunoocasali 🔥

@brunoocasali brunoocasali merged commit d3143b3 into bump-meilisearch-v0.29.0 Sep 5, 2022
@brunoocasali brunoocasali deleted the add-tests-to-matching branch September 5, 2022 14:25
bors bot added a commit that referenced this pull request Oct 3, 2022
523: Update version for the next release (v0.22.0) r=alallema a=brunoocasali

This version makes this package compatible with Meilisearch v0.29.0 🎉
Check out the changelog of [Meilisearch v0.29.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.29.0) for more information on the changes.

## 🚀 Enhancements

- Ensure support to the new search query parameter `matchingStrategy` (#522) `@brunoocasali` 
- Ensure support to keys with wildcarded actions.
  - `actions` field during key creation now accepts wildcards on actions. For example, `indexes.*` provides rights to `indexes.create`, `indexes.get`,`indexes.delete`, `indexes.delete`, and `indexes.update`. (#521) `@brunoocasali` 
  
## ⚠️ Breaking Changes

This breaking change *__may not affect you__*, but in any case, you should check your search queries if you want to keep the same behavior from `v0.28`.

- The `NOT` filter keyword does not have an implicitly `EXIST` operator anymore. Check out for more information: meilisearch/meilisearch#2486

Co-authored-by: Bruno Casali <[email protected]>
Co-authored-by: alallema <[email protected]>
Co-authored-by: Amélie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants