L4 integration: Modification to mphalport. #1921
Conversation
9167980 to
1cc81ed
Compare
| @@ -104,15 +104,15 @@ void mp_hal_gpio_clock_enable(GPIO_TypeDef *gpio) { | |||
| } else if (gpio == GPIOH) { | |||
| __GPIOH_CLK_ENABLE(); | |||
| #endif | |||
| #ifdef __GPIOI_CLK_ENABLE | |||
| #if defined(GPIOI) && defined(__GPIOI_CLK_ENABLE) | |||
There was a problem hiding this comment.
I don't understand the reason for this change.
There was a problem hiding this comment.
__GPIOI_CLK_ENABLE on L4 is defined in h1l/l4/inc/Legacy/stm32_hal_legacy.h, line 2214 as __HAL_RCC_GPIOI_CLK_ENABLE and this is no further defined on the l4 platform. Therefore I added the test for GPIOI which is not defined on l4 platform and both functions are needed to fullfill the code. According to the Reference Manual (RM0351, P277) the port can be A.H and there is no I, J ....
An alternative would be to check for the MCU_SERIES_L4 define.
There was a problem hiding this comment.
I ran into some of these when doing the M7 port as well.
Upgrading the latest F4 HAL (and changing all of the old defintions to the new ones) would help, then we could get rid of the legacy definitions. But that's also alot of work.
|
Thanks for the clarification. Merged in dda1a41. |
This is the 9th PR in a series (#1888, #1890, #1903, #1904, #1916, #1917, #1918, #1919, #1920 ) of PR to support the STM32L4 series in micropython. (see http://forum.micropython.org/viewtopic.php?f=12&t=1332&sid=64e2f63af49643c3edee159171f4a365)
This PR is independent of earlier PR.