L4 integration: Modifications to DAC. #1937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The HAL_DMA_Init function asserts that those fields are valid. By removing lines 400 & 401, those 2 fields (Channel & Direction) are essentially initialized to random values from the stack. |
|
These two fields are setup in the call to BTW. This PR can not compile as it uses the |
9167980 to
1cc81ed
Compare
4c7b574 to
cfa8dbe
Compare
cfa8dbe to
a7871c6
Compare
|
Close this PR as this changes are included in #1916. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR in a series (#1888, #1890, #1903, #1904, #1916, #1917, #1918, #1919, #1920, #1921, #1922, #1924, #1925, #1929 ) of PR to support the STM32L4 series in micropython. (see http://forum.micropython.org/viewtopic.php?f=12&t=1332&sid=64e2f63af49643c3edee159171f4a365)
Line 384-401 there were some changes due to new structure which is used to store the DMA stat in self. 384-386 I retrived the last dma which was setup on self. This dma is later deinitialized (line 407).
I am not sure what was the meaning of 400/401 which I removed from the source. I assume, that the DMA should be set up between the DAC instance number which was used in the constructor of it. In the old source there was always a DMA between DAC1 and the memory - which I assume is not the behaviour which the user assumes. Or where am I wrong?