rp2/machine_rtc: Check return value from rtc_set_alarm. #7392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Jun 13, 2021
ports/rp2/machine_rtc.c
Outdated
| @@ -100,7 +101,10 @@ STATIC mp_obj_t machine_rtc_datetime(mp_uint_t n_args, const mp_obj_t *args) { | |||
| .sec = mp_obj_get_int(items[6]), | |||
| }; | |||
|
|
|||
| rtc_set_datetime(&t); | |||
| ret = rtc_set_datetime(&t); | |||
There was a problem hiding this comment.
The usual style in MicroPython (C coding) is to declare variables (eg ret here) as late as possible. You could also just write it as if (!rtc_set_datetime(&t)) { ....
There was a problem hiding this comment.
@dpgeorge good point. I have uploaded the fixed version.
|
Regardless of any other changes (eg #7394), this is a good improvement. |
The rtc_set_datetime() from pico-sdk will validate the values in the datetime_t structure and refuse to set the time if they aren't valid. It makes sense to raise an exception if this happens instead of failing silently which might be confusing (as an example, see: micropython#6928 (comment) ).
|
Merged in e7f7094 (but I discarded the change to mbedtls submodule). |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Jan 4, 2023
Update pins.c for lolin_c3_mini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rtc_set_datetime() from pico-sdk will validate the values in the
datetime_t structure and refuse to set the time if they aren't valid. It
makes sense to raise an exception if this happens instead of failing
silently which might be confusing (as an example, see:
#6928 (comment)
).