You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@robert-hh@alphaFred I realised that some of the code in mimxrt is not being caught by the auto-formatter. We should fix this before more code is committed so that new code is formatted correctly.
I understand that some code in this port is copied from the NXP SDK, but it'd still be nice for consistency reasons to reformat it. After all, if code needs to be copied from the SDK into the port then it's because it needs to be customised and so we are free to reformat it.
To minimise diff, an alternative to this PR is for all the new code in #7767 to be formatted correctly, then when formatting is enabled the diff will be smaller.
While I regularly got formatting complaints about files in ports/mimxrt, there were no complaints about files in sub-directories. I assumed it was intentional, but still made some attempts to change the NXP style to a kind-of K&R style.
Looking at the formatting run you made, the files are now reformatted. So we will get them back to continue further work based on that.
After discussion with @alphaFred it looks easier if we reformat the files of #7767 with uncrustify. Then we do not have the risk of rebasing and this #7785 should not be needed any more.
it looks easier if we reformat the files of #7767 with uncrustify. Then we do not have the risk of rebasing and this #7785 should not be needed any more.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@robert-hh @alphaFred I realised that some of the code in mimxrt is not being caught by the auto-formatter. We should fix this before more code is committed so that new code is formatted correctly.
I understand that some code in this port is copied from the NXP SDK, but it'd still be nice for consistency reasons to reformat it. After all, if code needs to be copied from the SDK into the port then it's because it needs to be customised and so we are free to reformat it.
To minimise diff, an alternative to this PR is for all the new code in #7767 to be formatted correctly, then when formatting is enabled the diff will be smaller.