Thanks to visit codestin.com
Credit goes to github.com

Skip to content

mimxrt: reformat boards and hal source files #7785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dpgeorge
Copy link
Member

@robert-hh @alphaFred I realised that some of the code in mimxrt is not being caught by the auto-formatter. We should fix this before more code is committed so that new code is formatted correctly.

I understand that some code in this port is copied from the NXP SDK, but it'd still be nice for consistency reasons to reformat it. After all, if code needs to be copied from the SDK into the port then it's because it needs to be customised and so we are free to reformat it.

To minimise diff, an alternative to this PR is for all the new code in #7767 to be formatted correctly, then when formatting is enabled the diff will be smaller.

@codecov-commenter
Copy link

Codecov Report

Merging #7785 (04b0903) into master (426785a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7785   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         154      154           
  Lines       20042    20042           
=======================================
  Hits        19693    19693           
  Misses        349      349           
Impacted Files Coverage Δ
py/bc.c 88.65% <0.00%> (-1.04%) ⬇️
py/obj.c 98.01% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 426785a...04b0903. Read the comment docs.

@robert-hh
Copy link
Contributor

While I regularly got formatting complaints about files in ports/mimxrt, there were no complaints about files in sub-directories. I assumed it was intentional, but still made some attempts to change the NXP style to a kind-of K&R style.
Looking at the formatting run you made, the files are now reformatted. So we will get them back to continue further work based on that.

@robert-hh
Copy link
Contributor

After discussion with @alphaFred it looks easier if we reformat the files of #7767 with uncrustify. Then we do not have the risk of rebasing and this #7785 should not be needed any more.

@dpgeorge
Copy link
Member Author

it looks easier if we reformat the files of #7767 with uncrustify. Then we do not have the risk of rebasing and this #7785 should not be needed any more.

Sounds good!

@dpgeorge
Copy link
Member Author

Done as part of 0d7366c

@dpgeorge dpgeorge closed this Sep 14, 2021
@dpgeorge dpgeorge deleted the tools-codeformat-mimxrt-full branch September 14, 2021 12:18
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants