lan_iptest: Fit tests/run-multitests.py to the LAN interface. #8686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. This looks OK, it fixes the immediate problem. Rebased and merged in dd35f76 Ultimately there needs to be a more sophisticated way to detect the IP address (eg if a board has both WLAN and LAN and you want to run the tests on the LAN interface), but we can tackle that when we come to it. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Dec 4, 2023
Update to ESP IDF v5.1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only for WLAN the board's IP address was properly fetched. This PR addresses one error reported by #8681. The other two required fixes are covered by #8684 and #8678.
Indeed, many PRs for what seemed to be a single topic.