<ranges> Implement P2442R1 chunk_view
#2685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e977eb to
decb004
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Partially addresses microsoft#2539
miscco
commented
Apr 29, 2022
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
Reviewed everything but chunk_view<input_range>
strega-nil-ms
suggested changes
May 6, 2022
strega-nil-ms
approved these changes
May 6, 2022
StephanTLavavej
requested changes
May 10, 2022
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
suggested changes
May 12, 2022
StephanTLavavej
approved these changes
May 14, 2022
Member
|
I've pushed changes to address @CaseyCarter's feedback. I've also pushed an apparently-conflict-free merge with |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
chunk_viewchunk_view
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 16, 2022
CaseyCarter
approved these changes
May 16, 2022
Member
|
Merged with
|
Member
|
Thanks for implementing the second chunk of this C++23 ranges feature! 😹 🎉 😻 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the second part of P2442
chunk_viewAs always input ranges are a beauty to behold but...
Note I am not really sure about the access control of
outer-iterator::value_typeIt is depicted as a struct, but the setting kind of implies that we should guard access to its members.Also can someone explain why we always pass
*_Parentso that we needaddressofto reclaim the pointer instead of just the pointer.I tried to be clever with the noexcept specification. I thought I would remember that they need to be integer types or was it just integer-like? I usually assumed that assignment would be noexcept.
Partially fixes #2539