Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Boost to 1.81 #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 3 commits into from
Jan 12, 2023
Merged

Update Boost to 1.81 #3312

StephanTLavavej merged 3 commits into from
Jan 12, 2023

Conversation

@AZero13
Copy link
Contributor

@AZero13 AZero13 commented Dec 29, 2022

I will be the first to say it; I did in fact contribute to this release of Boost. However, it fixes a platitude of issues as this is a bugfix release.

Therefore, I think updating to 1.81 is worth it.

@AZero13 AZero13 requested a review from a team as a code owner December 29, 2022 18:49
@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Dec 30, 2022

This assertion failed, but I failed to reproduce the error on Godbolt...

STL/tests/std/tests/LWG3234_math_special_overloads/test.cpp

Line 200 in 8ddf4da

assert(comp_ellint_2(0) == acos(-1.0) / 2);

Perhaps we can (temporarily) change this line as indicated (2 might be replaced with some suitable relative error)

assert(expect_epsilons(comp_ellint_2(0), acos(-1.0) / 2, 2));

@fsb4000
Copy link
Contributor

fsb4000 commented Dec 30, 2022 •
edited
Loading

You also need to update this commit hash to f395de082eca6ee993a15f2bdb90277eda518295:

STL/docs/cgmanifest.json

Lines 8 to 9 in 8ddf4da

"repositoryUrl": "https://github.com/boostorg/math",
"commitHash": "db2a7cbb44a84c4c9cba62232c07f18b22bd965d"

@AZero13
Update Boost to 1.81
7b05d7a 
I will be the first to say it; I did in fact contribute to this release of Boost. However, it fixes a platitude of issues as this is a bugfix release.

Therefore, I think updating to 1.81 is worth it.
@AZero13
Copy link
Contributor Author

AZero13 commented Dec 30, 2022

Done!

@fsb4000
Copy link
Contributor

fsb4000 commented Dec 31, 2022 •
edited
Loading

Perhaps we can (temporarily) change this line

@frederick-vs-ja Do we need to create an issue about this (here or maybe in boost-math repo)?

@frederick-vs-ja frederick-vs-ja mentioned this pull request Dec 31, 2022
Closed
@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Dec 31, 2022

Perhaps we can (temporarily) change this line

@frederick-vs-ja Do we need to create an issue about this (here or maybe in boost-math repo)?

I think I've reproduced the error, so I reported the issue in boost-math repo.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jan 4, 2023
CaseyCarter
CaseyCarter approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I've verified that the commit hash corresponds to the boost-1.81.0 tag in the boost-math repo (https://github.com/boostorg/math/tags).

@fsb4000
Copy link
Contributor

fsb4000 commented Jan 6, 2023 

Error LNK2019: unresolved external symbol "void __cdecl std::swap<double,0>(double &,double &)" (??$swap@N$0A@@std@@YAXAEAN0@Z) referenced in function "bool __cdecl isclose<double>(double,double,int)" (??$isclose@N@@YA_NNNH@Z)

Adding #include <utility> fixed the test.

@StephanTLavavej StephanTLavavej self-assigned this Jan 11, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 11, 2023

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit fbed7ea into microsoft:main Jan 12, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 12, 2023

Thanks for updating the Boost.Math dependency! ✅ 🎉 😸

@StephanTLavavej StephanTLavavej mentioned this pull request Jan 19, 2023
Merged
@AZero13 AZero13 deleted the boost branch February 4, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+3 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AZero13 @frederick-vs-ja @fsb4000 @StephanTLavavej @CaseyCarter @strega-nil-ms @strega-nil