Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JMazurkiewicz
Copy link
Contributor

  • Renames:
    • _Lhs -> _Left,
    • _Rhs -> _Right,
    • indexes -> indices (part of several identifiers),
    • i -> _Ix (unreserved identifier),
    • result -> _Result (also unreserved identifier).
  • Style:
    • explicit(...) constexpr -> constexpr explicit(...) (looks like clang-format gives better result with the latter),
    • Remove double empty lines,
    • Always add empty line between functions,
    • Reorder span and const array& constructors of std::extents to match the synopsis (see [mdspan.extents]),
    • Add _Get_dynamic_indices function to _Mdspan_extent_type to avoid IIFE.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 3, 2023 21:48
@StephanTLavavej StephanTLavavej added enhancement Something can be improved mdspan C++23 mdspan labels Mar 3, 2023
@StephanTLavavej StephanTLavavej merged commit 02b0ecb into microsoft:feature/mdspan2 Mar 3, 2023
@JMazurkiewicz JMazurkiewicz deleted the mdspan/style branch March 3, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved mdspan C++23 mdspan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants