Thanks to visit codestin.com
Credit goes to github.com

P0009R18 `<mdspan>` #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

StephanTLavavej merged 77 commits into microsoft:main from StephanTLavavej:mdspan

Sep 14, 2023

Member

StephanTLavavej commented Aug 16, 2023 •

edited

Loading

Fixes #2909.

Thanks to @MattStephanson for starting this major feature branch with #3502, and to @JMazurkiewicz for finishing it with an incredible amount of work (#3534 #3535 #3560 #3564 #3580 #3586 #3593 #3603 #3615 #3616 #3632 #3672 #3673 #3674 #3682 #3688 #3689 #3690 #3693 #3694 #3698 #3701 #3702 #3715 #3749 #3767 #3786 #3821 #3825 #3829 #3847 #3852 wow!!!). Also thanks to @AlexGuteniev (#3944) and @frederick-vs-ja (#3638 #3901) for additional contributions. The feature branch also contains my own code review feedback (#3563 #3885 #3954 #3971), and merges from main by @CaseyCarter and myself to keep the branch active.

This will merge the feature branch feature/mdspan2 into main. It's a separate branch on my own fork so we can push additional last-minute commits if necessary, without going through multiple PRs. (Also, GitHub gets confused when directly merging between branches in the same fork.) Currently, this contains 3 additional commits:

Update the #endif comment next to the feature-test macro in <yvals_core.h> for consistency with recent cleanups.
Merge with main to resolve a trivial merge conflict in <yvals_core.h> around __cpp_lib_mdspan, as the formerly-adjacent __cpp_lib_modules has moved to the C++20 section.
Fix the stealth merge conflict that I foretold in Support the Standard Library Modules in C++20 mode #3977.

Followed by a bunch of commits from @CaseyCarter's code review.

⚠️ Reminder: this PR needs additional changes when merged to the internal MSVC repository ⚠️

Per https://github.com/microsoft/STL/wiki/Files-To-Edit-When-Adding-Or-Removing-Files.

MattStephanson and others added 30 commits

February 24, 2023 22:15


          Implement P0009R18 <mdspan> et al. (microsoft#3502)

69751ad

* First cut of `mdspan`, known to be incomplete.


          Merge pull request microsoft#3512 from microsoft/main

6bee593

Merge `main` to `feature/mdspan2`


          <mdspan>: Various cleanups (microsoft#3534)

02b0ecb


          <mdspan>: Implement *Mandates* clauses (microsoft#3535)

0314b17

Co-authored-by: Matt Stephanson <[email protected]>


          Merge pull request microsoft#3537 from microsoft/main

ed8d6d2

Merge `main` to `feature/mdspan2`


          Merge branch 'main' into update-mdspan2

05fb8e0


          Merge pull request microsoft#3549 from StephanTLavavej/update-mdspan2

a1054ad

Merge `main` to `feature/mdspan2`


          <mdspan>: Require concepts (microsoft#3560)


          <mdspan>: Add _EXPORT_STD, tiny cleanups (microsoft#3563)

5c2e59b


          <mdspan>: Use concepts everywhere and add mdspan deduction guides (…

187a036

…microsoft#3564)


          Merge pull request microsoft#3569 from microsoft/main

22838a9

Merge `main` to `feature/mdspan2`


          <mdspan>: Add separate tests for extents and default_accessor (m…

404605b

…icrosoft#3580)


          <mdspan>: Completely rework std::extents (microsoft#3586)

b0a6a97


          Merge pull request microsoft#3592 from microsoft/main

701f43d

Merge `main` to `feature/mdspan2`


          <mdspan>: Various cleanups (mostly renames) (microsoft#3593)

3ea5312


          Merge pull request microsoft#3597 from microsoft/main

f6687bf

Merge `main` to `feature/mdspan2`


          <mdspan>: layout_left improvements (microsoft#3603)

53d73ee


          <mdspan>: layout_right improvements (microsoft#3615)

74a6e2f


          <mdspan>: Improve accessor testing (microsoft#3616)

32853a6


          <mdspan>: Cleanup extents's deduction guide (microsoft#3632)

f4934c6


          Merge branch 'main' into unlimited-mdspan

46124c7


          <mdspan> needs <limits> for numeric_limits.

34fce78


          Merge pull request microsoft#3637 from StephanTLavavej/unlimited-mdspan

ba523a6

Merge `main` to `feature/mdspan2`, include `<limits>`


          Merge pull request microsoft#3653 from microsoft/main

c9b661c

Merge `main` to `feature/mdspan2`


          Merge pull request microsoft#3665 from microsoft/main

dc177d7

Merge `main` to `feature/mdspan2`


          <mdspan>: Cleanup mdspan class a little bit (microsoft#3672)


          <mdspan>: layout_stride improvements (microsoft#3673)

ea8995d


          <mdspan>: Reduce amount of function calls in non-optimized debug mo…

e4fb8fa

…de (microsoft#3674)


          <mdspan>: Diversify integer types used in tests (microsoft#3682)

2bb397c

Co-authored-by: Stephan T. Lavavej <[email protected]>


          <mdspan>: Add modules test (microsoft#3688)

1d70c09

Co-authored-by: Stephan T. Lavavej <[email protected]>

This comment was marked as resolved.

Sign in to view

StephanTLavavej assigned CaseyCarter


          Fix Clang 17 failures in P0009R18_mdspan_mdspan

d7fb94e

CaseyCarter suggested changes

View reviewed changes

Contributor

CaseyCarter left a comment •

edited

Loading

I've prepared fixes for these comments except for "_Fwd_prod_of_extents::_Calculate can potentially overflow when mdspan::size's precondition is satisfied", which I think deserves a bit of deep thinking and a followup issue. I'm going to PR a series of nicely fine-grained commits into STL's fork for ease of review.

stl/inc/mdspan Outdated Show resolved Hide resolved

stl/inc/mdspan Outdated Show resolved Hide resolved

stl/inc/mdspan Outdated Show resolved Hide resolved

stl/inc/mdspan Outdated Show resolved Hide resolved

stl/inc/mdspan Outdated Show resolved Hide resolved

tests/std/tests/P0009R18_mdspan_layout_stride/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0009R18_mdspan_layout_stride/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0009R18_mdspan_mdspan/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0009R18_mdspan_mdspan/test.cpp Show resolved Hide resolved

tests/std/include/test_mdspan_support.hpp Outdated Show resolved Hide resolved

CaseyCarter mentioned this pull request

Casey's mdspan review comments StephanTLavavej/STL#28

Closed

CaseyCarter and others added 13 commits

September 12, 2023 17:01


          Clarify error messages

a25bbfe


          Remove unnecessary _Size template parameter from extents constructor

89e7506


          Convert private extents constructor constraints to _STL_INTERNAL_STAT…

f2b4b5d

…IC_ASSERTs


          Extract _Construct_from_tuple from extents and rename to _Extents_fro…

ea8ea4a

…m_tuple


          Check layout_(left|right)::mapping constructor precondition everywher…

a3e66ad

…e the Standard mandates it


          "Helper" constructor of layout_stride::mapping should be private

946ff56


          test coverage for layout_stride::mapping with empty extents

29ed185

and fixes for the resulting failures.


          Defend against non-{}-constructible types

8a5c26d


          data_handle_type is always nothrow movable

0b4c7b1

... per the accessor policy requirements.


          Merge _Multidimensional_subscript overloads

4c4a04b

and avoid "detouring" through `operator[]` so we don't copy `OtherIndexType`s, which we aren't allowed to do. Fix test case that was expecting this bogosity.


          Detach comments to correct strange wrapping in P0009R18_mdspan_layout…

3382da9

…_stride


          Remove constexpr from undefined function declarations

90fb129


          _Ptr{} => _Ptr = data_handle_type()

7fe7858

StephanTLavavej mentioned this pull request

<mdspan>: _Fwd_prod_of_extents::_Calculate can potentially overflow when mdspan::size's precondition is satisfied #4023

Closed

StephanTLavavej requested a review from CaseyCarter

September 13, 2023 00:23

CaseyCarter approved these changes

View reviewed changes

CaseyCarter removed their assignment

Contributor

CaseyCarter commented Sep 13, 2023

🚀

Member Author

StephanTLavavej commented Sep 13, 2023

/azp run

azure-pipelines bot commented Sep 13, 2023

Azure Pipelines successfully started running 1 pipeline(s).

StephanTLavavej self-assigned this

Member Author

StephanTLavavej commented Sep 13, 2023

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej merged commit 23bc2a0 into microsoft:main

StephanTLavavej deleted the mdspan branch

September 14, 2023 18:59

Member Author

StephanTLavavej commented Sep 14, 2023

Thanks again @JMazurkiewicz, @MattStephanson, @AlexGuteniev, @frederick-vs-ja, and @CaseyCarter!

🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

jovibor jovibor left review comments

crtrott crtrott left review comments

achabense achabense left review comments

CaseyCarter CaseyCarter approved these changes

JMazurkiewicz JMazurkiewicz approved these changes

Labels