Thanks to visit codestin.com
Credit goes to github.com

Skip to content

<mdspan>: layout_right improvements #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 2 commits into from
Apr 4, 2023
Merged

<mdspan>: layout_right improvements #3615

StephanTLavavej merged 2 commits into from
Apr 4, 2023

Conversation

@JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Apr 3, 2023

layout_right:

  • Implement preconditions (checked unconditionally for now),
  • Fix is_(unique/exhaustive/strided) functions - all three should be static,
  • Implement rev-prod-of-extents function in extents,
  • Add separate regular tests and death tests.

layout_left:

  • Fix incorrect preconditions in constructor from layout_stride,
  • Fix tests and add extra coverage.

Testing:

  • Get rid of CanInvokeCallOperatorOfMapping concept and use already defined in helper header CheckCallOperatorOfLayoutMapping concept.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner April 3, 2023 12:01
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label Apr 3, 2023
StephanTLavavej
StephanTLavavej approved these changes Apr 4, 2023
View reviewed changes
@StephanTLavavej StephanTLavavej merged commit 74a6e2f into microsoft:feature/mdspan2 Apr 4, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Apr 4, 2023

Thanks! 😻 Merged with one tiny suggestion for followup.

@JMazurkiewicz JMazurkiewicz deleted the mdspan/layout_right branch April 4, 2023 00:23
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Apr 6, 2023
@JMazurkiewicz
Drive-by: alias repeating layout_right::mapping
6b1a478 
Comment: microsoft#3615 (comment)
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Apr 6, 2023
@JMazurkiewicz
Drive-by: alias repeating layout_right::mapping
d8dd87e 
Comment: microsoft#3615 (comment)
@JMazurkiewicz JMazurkiewicz mentioned this pull request Apr 6, 2023
Merged
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

No one assigned

Labels

mdspan C++23 mdspan

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JMazurkiewicz @StephanTLavavej