<mdspan>: Cache fwd-prod-of-extents and rev-prod-of-extents when all extents are static
#3715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
May 24, 2023
Member
|
Thanks for this neat perf improvement! 🚀 🐇 🐆 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all extents are static we can cache
fwd-prod-of-extentsandrev-prod-of-extents:_Fwd_prod_of_extentsand_Rev_prod_of_extentsare not member functions ofextentsanymore (they are classes),fwdorrevproducts.After getting WG21-P2647R1 in MSVC we can restore member functions and make caching arrays local to them.