Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JMazurkiewicz
Copy link
Contributor

  • Remove all suppressions from <mdspan> header,
  • Remove suppressions from tests where possible,
  • Reduce the size of code with suppressed warning and add TRANSITION, DevCom-923103 comments.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner May 10, 2023 16:19
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label May 10, 2023
@StephanTLavavej StephanTLavavej self-assigned this May 10, 2023
@StephanTLavavej
Copy link
Member

Thanks! Out of paranoia, I have adjusted one suppression to encompass the entire statement as we haven't done subexpression suppression (outside of perhaps some _Pragmas) elsewhere. Will merge after the tests cycle.

@StephanTLavavej
Copy link
Member

I've pushed a merge to resolve a conflict - the warning suppression is still necessary despite the change from == to cmp_equal.

@StephanTLavavej StephanTLavavej merged commit 4bd089b into microsoft:feature/mdspan2 May 11, 2023
@StephanTLavavej
Copy link
Member

Thanks for all of these <mdspan> PRs, this is great progress! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mdspan C++23 mdspan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants