Repeat export specifiers on definitions, so that they stay if the declarations are gone #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I understand what you're doing here, but can you please provide a PR description so that others can understand (both now, and people in the future doing PR archaeology)? For a PR fixing typos in comments, a title of "Fix typos" with no description would indeed be sufficient, but this PR is doing something much less obvious. |
Contributor
Author
|
Updated. |
Handling this variation is exactly what `_MRTIMP2_PURE` and `__CLRCALL_PURE_OR_CDECL` do.
StephanTLavavej
approved these changes
Aug 7, 2023
Member
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Aug 10, 2023
StephanTLavavej
approved these changes
Aug 10, 2023
Member
|
I've pushed a merge with |
Member
|
Thanks for fixing more of these inconsistencies and defending against future mistakes! 🛠️ 🛡️ 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have export specifiers on both function declaration and definition.
This is because after some future changes the declaration may be gone - either entirely, or header be no longer included.
By repeating export specifiers we make sure the function type and its impact on export surface stays the same.
See #3912 (comment)
Additionally, this simplifies the declarations in
stl/src/xmtx.hppto match the definitions (the declarations are functionally unchanged).