Remove unused functions from winapisupp.cpp
#3936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Aug 8, 2023
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Looks like a solid cleanup. I git grepped for all the affected names in the MSVC-internal repo - out of an overabundance of paranoia - and found no other occurrences of the removed names.
StephanTLavavej
approved these changes
Aug 8, 2023
Member
|
This is great! 😻 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
approved these changes
Aug 11, 2023
Member
|
I've pushed a merge with |
CaseyCarter
approved these changes
Aug 11, 2023
Member
|
Thanks for noticing and eliminating all of this dead code! 🧟 ☠️ 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3926
Mostly a red change
Also repeat
_CRTIMP2on__crtGetSystemTimePreciseAsFileTime-- see #3927