Maybe Clang _does_ work with ALTERNATENAME
#5098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable our `ALTERNATENAME` machinery when the compiler is Clang. Add Clang non-ASan coverage to `GH_002030_asan_annotate_{string,vector}`, which lets us simplify their matrices by extracting Asan-vs-not-ASan into a separate `RUNALL_CROSSLIST`.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
requested changes
Dec 3, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Dec 3, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
"I have many names." 👁️ 🔥 😈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable our
ALTERNATENAMEmachinery when the compiler is Clang. Add Clang non-ASan coverage toGH_002030_asan_annotate_{string,vector}, which lets us simplify their matrices by extracting the ASan/not-ASan distinction into a separateRUNALL_CROSSLIST.Let's hold this change for early in the 17.14 cycle instead of merging it now, super late in 17.13. I'd like to do some extra internal validation before merging as well: