Revert "Maybe Clang _does_ work with ALTERNATENAME (#5098)"
#5224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although #5098 merged successfully, recently the PR system has been persistently failing in an x86 Clang configuration of
std :: tests/Dev11_1086953_call_once_overhaul:39. This looks like:This is a false positive (which appears to only repro on our Server 2025 VMs; it doesn't repro on my local Win11 machine), which I suppose we could report to the relevant team at great effort. We could also just skip building this particular test for Clang x86.
However, reverting #5098 entirely appears to work robustly. Since I wasn't eager to mess with this in the first place, I think a revert is appropriate.
This preserves a comment improvement and adjusts other comments.