Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Jan 6, 2025

Although #5098 merged successfully, recently the PR system has been persistently failing in an x86 Clang configuration of std :: tests/Dev11_1086953_call_once_overhaul:39. This looks like:

name: std.tests/Dev11_1086953_call_once_overhaul
output: OSError(22, 'Operation did not complete successfully because the file contains a virus or potentially unwanted software', None, 225, None) at C:\a\_work\1\s\tests\utils\stl\test\format.py:231

This is a false positive (which appears to only repro on our Server 2025 VMs; it doesn't repro on my local Win11 machine), which I suppose we could report to the relevant team at great effort. We could also just skip building this particular test for Clang x86.

However, reverting #5098 entirely appears to work robustly. Since I wasn't eager to mess with this in the first place, I think a revert is appropriate.

This preserves a comment improvement and adjusts other comments.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jan 6, 2025
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner January 6, 2025 22:04
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ca2b2c6 into microsoft:main Jan 7, 2025
39 checks passed
@StephanTLavavej StephanTLavavej deleted the i-have-many-names branch January 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants