do not allocate a node if not needed in visitMehodDeclaration (#55)

microsoft · rbuckton · Mar 25, 2021 · Jan 15, 2021 · Jan 15, 2021 · Jan 18, 2021
commit 7490a36397b3dc4b9425b2293756e00d7b496148
diff --git a/src/compiler/transformers/classFields.ts b/src/compiler/transformers/classFields.ts
@@ -278,10 +278,9 @@ namespace ts {
 
         function visitMethodOrAccessorDeclaration(node: MethodDeclaration | AccessorDeclaration) {
             Debug.assert(!some(node.decorators));
-            const transformedMethod = visitEachChild(node, classElementVisitor, context);
 
-            if (!shouldTransformPrivateElements || !isPrivateIdentifier(node.name) || !transformedMethod.body) {
-                return transformedMethod;
+            if (!shouldTransformPrivateElements || !isPrivateIdentifier(node.name)) {
+                return visitEachChild(node, classElementVisitor, context);
             }
 
             const functionName = getHoistedFunctionName(node);
@@ -290,13 +289,13 @@ namespace ts {
                     factory.createAssignment(
                         functionName,
                         factory.createFunctionExpression(
-                            filter(transformedMethod.modifiers, m => !isStaticModifier(m)),
-                            transformedMethod.asteriskToken,
+                            filter(node.modifiers, m => !isStaticModifier(m)),
+                            node.asteriskToken,
                             functionName,
-                            transformedMethod.typeParameters,
-                            transformedMethod.parameters,
-                            transformedMethod.type,
-                            transformedMethod.body
+                            /* typeParameters */ undefined,
+                            visitParameterList(node.parameters, classElementVisitor, context),
+                            /* type */ undefined,
+                            visitFunctionBody(node.body!, classElementVisitor, context)
                         )
                     )
                 );