Added error for using a set only accessor.

microsoft · rbuckton · Mar 25, 2021 · Jan 15, 2021 · Jan 15, 2021 · Jan 18, 2021
commit ff2463660b7328e551848f176e6e83df2437db22
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -26815,6 +26815,12 @@ namespace ts {
                 if (!prop && checkPrivateIdentifierPropertyAccess(leftType, right, lexicallyScopedSymbol)) {
                     return errorType;
                 }
+                else {
+                    const isSetonlyAccessor = prop && prop.flags & SymbolFlags.SetAccessor && !(prop.flags & SymbolFlags.GetAccessor);
+                    if (isSetonlyAccessor && !isAssignmentTarget(node)) {
+                        error(node, Diagnostics.Private_accessor_was_defined_without_a_getter);
+                    }
+                }
             }
             else {
                 if (isAnyLike) {

diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -3296,6 +3296,10 @@
         "category": "Error",
         "code": 2805
     },
+    "Private accessor was defined without a getter.": {
+        "category": "Error",
+        "code": 2806
+    },
 
     "Import declaration '{0}' is using private name '{1}'.": {
         "category": "Error",

diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -2706,6 +2706,9 @@ namespace ts {
                 case SyntaxKind.NonNullExpression:
                     node = parent;
                     break;
+                case SyntaxKind.SpreadAssignment:
+                    node = parent.parent;
+                    break;
                 case SyntaxKind.ShorthandPropertyAssignment:
                     if ((parent as ShorthandPropertyAssignment).name !== node) {
                         return AssignmentKind.None;
@@ -4814,6 +4817,9 @@ namespace ts {
             && isLeftHandSideExpression(node.left);
     }
 
+    export function isLeftHandSideOfAssignment(node: Node) {
+        return isAssignmentExpression(node.parent) && node.parent.left === node;
+    }
     export function isDestructuringAssignment(node: Node): node is DestructuringAssignment {
         if (isAssignmentExpression(node, /*excludeCompoundAssignment*/ true)) {
             const kind = node.left.kind;

diff --git a/tests/baselines/reference/privateWriteOnlyAccessorRead.errors.txt b/tests/baselines/reference/privateWriteOnlyAccessorRead.errors.txt
@@ -0,0 +1,55 @@
+tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts(8,17): error TS2806: Private accessor was defined without a getter.
+tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts(11,5): error TS2806: Private accessor was defined without a getter.
+tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts(16,13): error TS2806: Private accessor was defined without a getter.
+tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts(18,17): error TS2806: Private accessor was defined without a getter.
+tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts(21,18): error TS2806: Private accessor was defined without a getter.
+tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts(25,9): error TS2806: Private accessor was defined without a getter.
+tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts(26,12): error TS2806: Private accessor was defined without a getter.
+
+
+==== tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts (7 errors) ====
+    class Test {
+      set #value(v: { foo: { bar: number } }) {}
+      set #valueRest(v: number[]) {}
+      set #valueOne(v: number) {}
+
+      m() {
+        const foo = { bar: 1 };
+        console.log(this.#value); // error
+                    ~~~~~~~~~~~
+!!! error TS2806: Private accessor was defined without a getter.
+        this.#value = { foo }; // ok
+        this.#value = { foo }; // ok
+        this.#value.foo = foo; // error
+        ~~~~~~~~~~~
+!!! error TS2806: Private accessor was defined without a getter.
+
+        ({ o: this.#value } = { o: { foo } }); //ok
+        ({ ...this.#value } = { foo }); //ok
+
+        ({ foo: this.#value.foo } = { foo }); //error
+                ~~~~~~~~~~~
+!!! error TS2806: Private accessor was defined without a getter.
+        ({
+          foo: { ...this.#value.foo },
+                    ~~~~~~~~~~~
+!!! error TS2806: Private accessor was defined without a getter.
+        } = { foo }); //error
+
+        let r = { o: this.#value }; //error
+                     ~~~~~~~~~~~
+!!! error TS2806: Private accessor was defined without a getter.
+
+        [this.#valueOne, ...this.#valueRest] = [1, 2, 3];
+        let arr = [
+            this.#valueOne,
+            ~~~~~~~~~~~~~~
+!!! error TS2806: Private accessor was defined without a getter.
+            ...this.#valueRest
+               ~~~~~~~~~~~~~~~
+!!! error TS2806: Private accessor was defined without a getter.
+        ];
+      }
+    }
+    new Test().m();
+
diff --git a/tests/baselines/reference/privateWriteOnlyAccessorRead.js b/tests/baselines/reference/privateWriteOnlyAccessorRead.js
@@ -0,0 +1,87 @@
+//// [privateWriteOnlyAccessorRead.ts]
+class Test {
+  set #value(v: { foo: { bar: number } }) {}
+  set #valueRest(v: number[]) {}
+  set #valueOne(v: number) {}
+
+  m() {
+    const foo = { bar: 1 };
+    console.log(this.#value); // error
+    this.#value = { foo }; // ok
+    this.#value = { foo }; // ok
+    this.#value.foo = foo; // error
+
+    ({ o: this.#value } = { o: { foo } }); //ok
+    ({ ...this.#value } = { foo }); //ok
+
+    ({ foo: this.#value.foo } = { foo }); //error
+    ({
+      foo: { ...this.#value.foo },
+    } = { foo }); //error
+
+    let r = { o: this.#value }; //error
+
+    [this.#valueOne, ...this.#valueRest] = [1, 2, 3];
+    let arr = [
+        this.#valueOne,
+        ...this.#valueRest
+    ];
+  }
+}
+new Test().m();
+
+
+//// [privateWriteOnlyAccessorRead.js]
+var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (receiver, state, kind, f) {
+    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter");
+    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
+    return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
+};
+var __classPrivateFieldSet = (this && this.__classPrivateFieldSet) || function (receiver, state, value, kind, f) {
+    if (kind === "m") throw new TypeError("Private method is not writable");
+    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a setter");
+    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot write private member to an object whose class did not declare it");
+    return (kind === "a" ? f.call(receiver, value) : f ? f.value = value : state.set(receiver, value)), value;
+};
+var __rest = (this && this.__rest) || function (s, e) {
+    var t = {};
+    for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
+        t[p] = s[p];
+    if (s != null && typeof Object.getOwnPropertySymbols === "function")
+        for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) {
+            if (e.indexOf(p[i]) < 0 && Object.prototype.propertyIsEnumerable.call(s, p[i]))
+                t[p[i]] = s[p[i]];
+        }
+    return t;
+};
+var _Test_instances, _Test_value_set, _Test_valueRest_set, _Test_valueOne_set;
+class Test {
+    constructor() {
+        _Test_instances.add(this);
+    }
+    m() {
+        var _a, _b, _c;
+        const foo = { bar: 1 };
+        console.log(__classPrivateFieldGet(this, _Test_instances, "a")); // error
+        __classPrivateFieldSet(// error
+        this, _Test_instances, { foo }, "a", _Test_value_set); // ok
+        __classPrivateFieldSet(// ok
+        this, _Test_instances, { foo }, "a", _Test_value_set); // ok
+        __classPrivateFieldGet(// ok
+        this, _Test_instances, "a").foo = foo; // error
+        (_a = this, { o: ({ set value(_d) { __classPrivateFieldSet(_a, _Test_instances, _d, "a", _Test_value_set); } }).value } = { o: { foo } }); //ok
+        (__classPrivateFieldGet(this, _Test_instances, "a") = __rest({ foo }, [])); //ok
+        ({ foo: __classPrivateFieldGet(this, _Test_instances, "a").foo } = { foo }); //error
+        ({
+            foo: Object.assign({}, __classPrivateFieldGet(this, _Test_instances, "a").foo),
+        } = { foo }); //error
+        let r = { o: __classPrivateFieldGet(this, _Test_instances, "a") }; //error
+        _b = this, _c = this, [({ set value(_d) { __classPrivateFieldSet(_b, _Test_instances, _d, "a", _Test_valueOne_set); } }).value, ...({ set value(_d) { __classPrivateFieldSet(_c, _Test_instances, _d, "a", _Test_valueRest_set); } }).value] = [1, 2, 3];
+        let arr = [
+            __classPrivateFieldGet(this, _Test_instances, "a"),
+            ...__classPrivateFieldGet(this, _Test_instances, "a")
+        ];
+    }
+}
+_Test_instances = new WeakSet(), _Test_value_set = function _Test_value_set(v) { }, _Test_valueRest_set = function _Test_valueRest_set(v) { }, _Test_valueOne_set = function _Test_valueOne_set(v) { };
+new Test().m();
diff --git a/tests/baselines/reference/privateWriteOnlyAccessorRead.symbols b/tests/baselines/reference/privateWriteOnlyAccessorRead.symbols
@@ -0,0 +1,111 @@
+=== tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts ===
+class Test {
+>Test : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+
+  set #value(v: { foo: { bar: number } }) {}
+>#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>v : Symbol(v, Decl(privateWriteOnlyAccessorRead.ts, 1, 13))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
+>bar : Symbol(bar, Decl(privateWriteOnlyAccessorRead.ts, 1, 24))
+
+  set #valueRest(v: number[]) {}
+>#valueRest : Symbol(Test.#valueRest, Decl(privateWriteOnlyAccessorRead.ts, 1, 44))
+>v : Symbol(v, Decl(privateWriteOnlyAccessorRead.ts, 2, 17))
+
+  set #valueOne(v: number) {}
+>#valueOne : Symbol(Test.#valueOne, Decl(privateWriteOnlyAccessorRead.ts, 2, 32))
+>v : Symbol(v, Decl(privateWriteOnlyAccessorRead.ts, 3, 16))
+
+  m() {
+>m : Symbol(Test.m, Decl(privateWriteOnlyAccessorRead.ts, 3, 29))
+
+    const foo = { bar: 1 };
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 6, 9))
+>bar : Symbol(bar, Decl(privateWriteOnlyAccessorRead.ts, 6, 17))
+
+    console.log(this.#value); // error
+>console.log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
+>console : Symbol(console, Decl(lib.dom.d.ts, --, --))
+>log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
+>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+
+    this.#value = { foo }; // ok
+>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 8, 19))
+
+    this.#value = { foo }; // ok
+>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 9, 19))
+
+    this.#value.foo = foo; // error
+>this.#value.foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
+>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 6, 9))
+
+    ({ o: this.#value } = { o: { foo } }); //ok
+>o : Symbol(o, Decl(privateWriteOnlyAccessorRead.ts, 12, 6))
+>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+>o : Symbol(o, Decl(privateWriteOnlyAccessorRead.ts, 12, 27))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 12, 32))
+
+    ({ ...this.#value } = { foo }); //ok
+>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 13, 27))
+
+    ({ foo: this.#value.foo } = { foo }); //error
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 15, 6))
+>this.#value.foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
+>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 15, 33))
+
+    ({
+      foo: { ...this.#value.foo },
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 16, 6))
+>this.#value.foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
+>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
+
+    } = { foo }); //error
+>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 18, 9))
+
+    let r = { o: this.#value }; //error
+>r : Symbol(r, Decl(privateWriteOnlyAccessorRead.ts, 20, 7))
+>o : Symbol(o, Decl(privateWriteOnlyAccessorRead.ts, 20, 13))
+>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+
+    [this.#valueOne, ...this.#valueRest] = [1, 2, 3];
+>this.#valueOne : Symbol(Test.#valueOne, Decl(privateWriteOnlyAccessorRead.ts, 2, 32))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+>this.#valueRest : Symbol(Test.#valueRest, Decl(privateWriteOnlyAccessorRead.ts, 1, 44))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+
+    let arr = [
+>arr : Symbol(arr, Decl(privateWriteOnlyAccessorRead.ts, 23, 7))
+
+        this.#valueOne,
+>this.#valueOne : Symbol(Test.#valueOne, Decl(privateWriteOnlyAccessorRead.ts, 2, 32))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+
+        ...this.#valueRest
+>this.#valueRest : Symbol(Test.#valueRest, Decl(privateWriteOnlyAccessorRead.ts, 1, 44))
+>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+
+    ];
+  }
+}
+new Test().m();
+>new Test().m : Symbol(Test.m, Decl(privateWriteOnlyAccessorRead.ts, 3, 29))
+>Test : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
+>m : Symbol(Test.m, Decl(privateWriteOnlyAccessorRead.ts, 3, 29))
+