Avoid resolving source prop type when the target is unknown/any
#61660
+835
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5da502 to
8289db7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves the performance and accuracy of type checking for property symbols by short‐circuiting the relation check when the target type is “any” (or “any”/“unknown” when not using strict subtype relation).
- Introduces a new condition in isPropertySymbolTypeRelated that returns Ternary.True when the effective target’s flags indicate “any” (or “any”/“unknown” depending on the relation), thereby avoiding unnecessary resolution of the source property type.
- Adds an explanatory comment to document this behavior per issue Support cyclical type inference of self-referential data structures, when subject to some assignability constraints #61659.
Files not reviewed (5)
- tests/baselines/reference/multiline.types: Language not supported
- tests/baselines/reference/noCircularitySelfReferentialGetter1.symbols: Language not supported
- tests/baselines/reference/noCircularitySelfReferentialGetter1.types: Language not supported
- tests/baselines/reference/noCircularitySelfReferentialGetter2.symbols: Language not supported
- tests/baselines/reference/noCircularitySelfReferentialGetter2.types: Language not supported
| @@ -24057,6 +24057,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker { | |||
| function isPropertySymbolTypeRelated(sourceProp: Symbol, targetProp: Symbol, getTypeOfSourceProperty: (sym: Symbol) => Type, reportErrors: boolean, intersectionState: IntersectionState): Ternary { | |||
| const targetIsOptional = strictNullChecks && !!(getCheckFlags(targetProp) & CheckFlags.Partial); | |||
| const effectiveTarget = addOptionality(getNonMissingTypeOfSymbol(targetProp), /*isProperty*/ false, targetIsOptional); | |||
| // source could resolve to `any` and that's not related to `unknown` target under strict subtype relation | |||
| if (effectiveTarget.flags & (relation === strictSubtypeRelation ? TypeFlags.Any : TypeFlags.AnyOrUnknown)) { | |||
There was a problem hiding this comment.
The condition now short-circuits the type relation check when the target type is 'any' (or 'any'/'unknown' depending on the relation), which is the intended behavior per issue #61659. Consider adding a reference to the issue number in the comment for clearer context and future maintainability.
Copilot uses AI. Check for mistakes.
8289db7 to
540e84d
Compare
|
I will just pop in here to note that this would presumably hep with a number of circularities I've experienced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #61659