Avoid resolving source prop type when the target is `unknown`/`any` #61660

Andarist · 2025-05-05T09:54:00Z

Copilot

Pull Request Overview

This PR improves the performance and accuracy of type checking for property symbols by short‐circuiting the relation check when the target type is “any” (or “any”/“unknown” when not using strict subtype relation).

Introduces a new condition in isPropertySymbolTypeRelated that returns Ternary.True when the effective target’s flags indicate “any” (or “any”/“unknown” depending on the relation), thereby avoiding unnecessary resolution of the source property type.
Adds an explanatory comment to document this behavior per issue Support cyclical type inference of self-referential data structures, when subject to some assignability constraints #61659.

Files not reviewed (5)

tests/baselines/reference/multiline.types: Language not supported
tests/baselines/reference/noCircularitySelfReferentialGetter1.symbols: Language not supported
tests/baselines/reference/noCircularitySelfReferentialGetter1.types: Language not supported
tests/baselines/reference/noCircularitySelfReferentialGetter2.symbols: Language not supported
tests/baselines/reference/noCircularitySelfReferentialGetter2.types: Language not supported

Copilot · 2025-05-05T09:54:32Z

src/compiler/checker.ts

@@ -24057,6 +24057,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
        function isPropertySymbolTypeRelated(sourceProp: Symbol, targetProp: Symbol, getTypeOfSourceProperty: (sym: Symbol) => Type, reportErrors: boolean, intersectionState: IntersectionState): Ternary {
            const targetIsOptional = strictNullChecks && !!(getCheckFlags(targetProp) & CheckFlags.Partial);
            const effectiveTarget = addOptionality(getNonMissingTypeOfSymbol(targetProp), /*isProperty*/ false, targetIsOptional);
+            // source could resolve to `any` and that's not related to `unknown` target under strict subtype relation
+            if (effectiveTarget.flags & (relation === strictSubtypeRelation ? TypeFlags.Any : TypeFlags.AnyOrUnknown)) {


The condition now short-circuits the type relation check when the target type is 'any' (or 'any'/'unknown' depending on the relation), which is the intended behavior per issue #61659. Consider adding a reference to the issue number in the comment for clearer context and future maintainability.

LukeAbby · 2025-05-05T11:08:15Z

I will just pop in here to note that this would presumably hep with a number of circularities I've experienced.

RyanCavanaugh · 2025-05-06T23:36:11Z

@typescript-bot test it

Andarist · 2025-05-07T04:55:00Z

@RyanCavanaugh it looks like the bot didnt pick this up. Could you try again?

jakebailey · 2025-05-07T16:20:57Z

The bot is broken, I am fixing it.

jakebailey · 2025-05-07T19:45:32Z

@typescript-bot test it

jakebailey · 2025-05-07T22:11:43Z

@typescript-bot test it

typescript-bot · 2025-05-07T22:11:48Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-05-07T22:35:26Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-05-07T22:36:13Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61660/merge:

Everything looks good!

typescript-bot · 2025-05-07T23:07:21Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{196,059k (± 0.74%)}	_{196,078k (± 0.73%)}	_~	_193,153k	_196,688k	_{p=0.810 n=6}
_{Parse Time}	_{1.60s (± 1.65%)}	_{1.60s (± 1.83%)}	_~	_1.55s	_1.64s	_{p=0.871 n=6}
_{Bind Time}	_0.89s	_{0.89s (± 2.30%)}	_~	_0.87s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{11.79s (± 0.57%)}	_{11.79s (± 0.55%)}	_~	_11.73s	_11.92s	_{p=0.872 n=6}
_{Emit Time}	_{3.29s (± 1.07%)}	_{3.31s (± 1.17%)}	_~	_3.26s	_3.36s	_{p=0.374 n=6}
_{Total Time}	_{17.56s (± 0.46%)}	_{17.59s (± 0.60%)}	_~	_17.49s	_17.74s	_{p=0.748 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_949,240	_949,249	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_411,065	_411,061	_{-4 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,225,308k (± 0.00%)}	_{1,225,239k (± 0.00%)}	_{-70k (- 0.01%)}	_1,225,195k	_1,225,288k	_{p=0.031 n=6}
_{Parse Time}	_{8.04s (± 1.13%)}	_{8.03s (± 0.82%)}	_~	_7.94s	_8.11s	_{p=0.872 n=6}
_{Bind Time}	_{2.29s (± 1.06%)}	_{2.27s (± 0.37%)}	_~	_2.27s	_2.29s	_{p=0.120 n=6}
_{Check Time}	_{38.08s (± 0.20%)}	_{38.20s (± 0.44%)}	_~	_37.95s	_38.42s	_{p=0.149 n=6}
_{Emit Time}	_{18.31s (± 0.45%)}	_{18.33s (± 0.55%)}	_~	_18.20s	_18.46s	_{p=0.575 n=6}
_{Total Time}	_{66.72s (± 0.20%)}	_{66.85s (± 0.19%)}	_~	_66.70s	_67.07s	_{p=0.173 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,439,929	_2,439,624	_{-305 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_872,556	_872,323	_{-233 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,448,472k (± 0.00%)}	_{2,448,203k (± 0.00%)}	_{-269k (- 0.01%)}	_2,448,145k	_2,448,269k	_{p=0.005 n=6}
_{Parse Time}	_{10.59s (± 0.27%)}	_{10.57s (± 0.33%)}	_~	_10.51s	_10.61s	_{p=1.000 n=6}
_{Bind Time}	_{2.69s (± 0.72%)}	_{2.71s (± 0.96%)}	_~	_2.67s	_2.75s	_{p=0.168 n=6}
_{Check Time}	_{87.13s (± 1.64%)}	_{87.87s (± 3.35%)}	_~	_86.10s	_93.77s	_{p=0.936 n=6}
_{Emit Time}	_{0.37s (± 2.22%)}	_{0.37s (± 3.17%)}	_~	_0.36s	_0.39s	_{p=1.000 n=6}
_{Total Time}	_{100.77s (± 1.43%)}	_{101.52s (± 2.92%)}	_~	_99.68s	_107.46s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,052	_1,228,052	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,262	_267,263	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,972,556k (±10.03%)}	_{2,850,877k (±13.24%)}	_~	_2,363,094k	_3,095,377k	_{p=0.936 n=6}
_{Parse Time}	_{6.70s (± 0.96%)}	_{6.63s (± 1.54%)}	_~	_6.49s	_6.75s	_{p=0.230 n=6}
_{Bind Time}	_{2.14s (± 2.20%)}	_{2.15s (± 1.44%)}	_~	_2.12s	_2.20s	_{p=0.872 n=6}
_{Check Time}	_{42.86s (± 0.47%)}	_{42.91s (± 0.41%)}	_~	_42.63s	_43.11s	_{p=0.936 n=6}
_{Emit Time}	_{3.52s (± 2.38%)}	_{3.50s (± 1.89%)}	_~	_3.43s	_3.59s	_{p=0.521 n=6}
_{Total Time}	_{55.22s (± 0.62%)}	_{55.20s (± 0.39%)}	_~	_54.80s	_55.37s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,052	_1,228,052	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,262	_267,263	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,917,476k (±12.85%)}	_{2,821,496k (±13.27%)}	_~	_2,430,261k	_3,160,100k	_{p=0.471 n=6}
_{Parse Time}	_{8.57s (± 1.79%)}	_{8.53s (± 1.30%)}	_~	_8.42s	_8.68s	_{p=0.374 n=6}
_{Bind Time}	_{2.68s (± 1.91%)}	_{2.67s (± 1.58%)}	_~	_2.62s	_2.73s	_{p=0.630 n=6}
_{Check Time}	_{52.93s (± 0.63%)}	_{52.98s (± 0.71%)}	_~	_52.35s	_53.36s	_{p=0.936 n=6}
_{Emit Time}	_{4.29s (± 2.38%)}	_{4.34s (± 2.35%)}	_~	_4.18s	_4.44s	_{p=0.423 n=6}
_{Total Time}	_{68.47s (± 0.70%)}	_{68.52s (± 0.61%)}	_~	_67.95s	_69.09s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,419	_263,419	_~	_~	_~	_{p=1.000 n=6}
_Types	_107,098	_107,099	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,811k (± 0.02%)}	_{441,830k (± 0.02%)}	_~	_441,712k	_441,938k	_{p=0.689 n=6}
_{Parse Time}	_{3.53s (± 1.04%)}	_{3.54s (± 1.09%)}	_~	_3.47s	_3.57s	_{p=0.376 n=6}
_{Bind Time}	_{1.33s (± 1.10%)}	_{1.33s (± 0.57%)}	_~	_1.32s	_1.34s	_{p=0.620 n=6}
_{Check Time}	_{19.10s (± 0.24%)}	_{19.04s (± 0.34%)}	_~	_18.98s	_19.12s	_{p=0.253 n=6}
_{Emit Time}	_{1.53s (± 1.01%)}	_{1.55s (± 1.33%)}	_~	_1.53s	_1.59s	_{p=0.052 n=6}
_{Total Time}	_{25.49s (± 0.24%)}	_{25.47s (± 0.32%)}	_~	_25.37s	_25.59s	_{p=0.747 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,981	_225,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,356	_94,356	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,338k (± 0.04%)}	_{371,454k (± 0.06%)}	_~	_371,205k	_371,761k	_{p=0.630 n=6}
_{Parse Time}	_{3.61s (± 0.69%)}	_{3.60s (± 0.21%)}	_~	_3.59s	_3.61s	_{p=0.415 n=6}
_{Bind Time}	_{1.99s (± 0.82%)}	_{1.97s (± 1.11%)}	_~	_1.94s	_2.00s	_{p=0.076 n=6}
_{Check Time}	_{20.49s (± 0.15%)}	_{20.55s (± 0.22%)}	_~	_20.50s	_20.62s	_{p=0.065 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.09s (± 0.19%)}	_{26.12s (± 0.23%)}	_~	_26.06s	_26.21s	_{p=0.688 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₅₁	₅₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,419,896	_3,419,897	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,154,013	_1,153,984	_{-29 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,472,378k (± 0.01%)}	_{3,472,416k (± 0.00%)}	_~	_3,472,198k	_3,472,712k	_{p=0.689 n=6}
_{Parse Time}	_{18.39s (± 0.82%)}	_{18.26s (± 1.01%)}	_~	_18.05s	_18.56s	_{p=0.173 n=6}
_{Bind Time}	_{5.83s (± 0.46%)}	_{5.84s (± 0.68%)}	_~	_5.79s	_5.89s	_{p=0.808 n=6}
_{Check Time}	_{118.16s (± 3.52%)}	_{114.37s (± 1.55%)}	_~	_113.05s	_117.90s	_{p=0.298 n=6}
_{Emit Time}	_{37.32s (± 2.42%)}	_{36.86s (± 1.97%)}	_~	_36.23s	_38.29s	_{p=0.630 n=6}
_{Total Time}	_{179.70s (± 2.62%)}	_{175.33s (± 1.45%)}	_~	_173.73s	_180.47s	_{p=0.173 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_317,848	_317,854	_{+6 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_140,485	_140,476	_{-9 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{473,064k (± 0.04%)}	_{473,112k (± 0.02%)}	_~	_472,940k	_473,189k	_{p=0.575 n=6}
_{Parse Time}	_{5.16s (± 0.51%)}	_{5.18s (± 0.35%)}	_~	_5.15s	_5.20s	_{p=0.101 n=6}
_{Bind Time}	_{2.27s (± 1.94%)}	_{2.23s (± 1.05%)}	_~	_2.20s	_2.26s	_{p=0.091 n=6}
_{Check Time}	_{25.92s (± 0.34%)}	_{25.93s (± 0.41%)}	_~	_25.79s	_26.10s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{33.36s (± 0.36%)}	_{33.34s (± 0.31%)}	_~	_33.22s	_33.51s	_{p=0.748 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_570,733	_559,890	_{-10,843 (- 1.90%)}	_~	_~	_{p=0.001 n=6}
_Types	_191,446	_191,112	_{-334 (- 0.17%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{501,304k (± 0.01%)}	_{496,297k (± 0.04%)}	_{-5,007k (- 1.00%)}	_495,921k	_496,465k	_{p=0.005 n=6}
_{Parse Time}	_{3.48s (± 0.44%)}	_{3.48s (± 0.76%)}	_~	_3.45s	_3.52s	_{p=0.808 n=6}
_{Bind Time}	_{1.23s (± 1.40%)}	_{1.24s (± 0.61%)}	_~	_1.23s	_1.25s	_{p=0.087 n=6}
_{Check Time}	_{20.17s (± 0.26%)}	_{20.23s (± 2.86%)}	_~	_19.95s	_21.41s	_{p=0.092 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.88s (± 0.19%)}	_{24.96s (± 2.24%)}	_~	_24.65s	_26.09s	_{p=0.108 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-05-07T23:55:40Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61660/merge:

Everything looks good!

Copilot AI review requested due to automatic review settings May 5, 2025 09:54

Andarist force-pushed the avoid-circularity-on-any-unknown-target-props branch from c5da502 to 8289db7 Compare May 5, 2025 09:54

github-project-automation bot added this to PR Backlog May 5, 2025

github-project-automation bot moved this to Not started in PR Backlog May 5, 2025

typescript-bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 5, 2025

Copilot AI reviewed May 5, 2025

View reviewed changes

Avoid resolving source prop type when the target is unknown/any

540e84d

Andarist force-pushed the avoid-circularity-on-any-unknown-target-props branch from 8289db7 to 540e84d Compare May 5, 2025 09:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid resolving source prop type when the target is `unknown`/`any` #61660

Avoid resolving source prop type when the target is `unknown`/`any` #61660

Andarist commented May 5, 2025

Copilot AI left a comment

Copilot AI May 5, 2025

LukeAbby commented May 5, 2025

RyanCavanaugh commented May 6, 2025

Andarist commented May 7, 2025

jakebailey commented May 7, 2025

jakebailey commented May 7, 2025

jakebailey commented May 7, 2025

typescript-bot commented May 7, 2025 •

edited

Loading

typescript-bot commented May 7, 2025

typescript-bot commented May 7, 2025

typescript-bot commented May 7, 2025

tsc

typescript-bot commented May 7, 2025

Avoid resolving source prop type when the target is unknown/any #61660

Are you sure you want to change the base?

Avoid resolving source prop type when the target is unknown/any #61660

Conversation

Andarist commented May 5, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Copilot AI May 5, 2025

Choose a reason for hiding this comment

LukeAbby commented May 5, 2025

RyanCavanaugh commented May 6, 2025

Andarist commented May 7, 2025

jakebailey commented May 7, 2025

jakebailey commented May 7, 2025

jakebailey commented May 7, 2025

typescript-bot commented May 7, 2025 • edited Loading

typescript-bot commented May 7, 2025

typescript-bot commented May 7, 2025

typescript-bot commented May 7, 2025

tsc

typescript-bot commented May 7, 2025

Avoid resolving source prop type when the target is `unknown`/`any` #61660

Avoid resolving source prop type when the target is `unknown`/`any` #61660

typescript-bot commented May 7, 2025 •

edited

Loading