Port "Narrow types by satisfies expressions" #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Ports the TypeScript change “Narrow types by satisfies expressions” to downstream flow analysis and updates related test baselines.
- Updated several test baselines to reflect new narrowing behavior when a predicate uses
satisfies. - Adjusted declaration and JS baselines for
isEmptyStringto restore its type‐predicate signature. - Enhanced
flow.goto recognizeSatisfiesExpressionin type narrowing and reference matching.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/baselines/reference/submodule/compiler/inferTypePredicates.types.diff | Updated expected outputs for .filter(... satisfies boolean) and isEmptyString. |
| testdata/baselines/reference/submodule/compiler/inferTypePredicates.types | Refined type annotations for filter result and predicate signature. |
| testdata/baselines/reference/submodule/compiler/inferTypePredicates.js.diff | Cleaned up intermediate boolean signature change for isEmptyString. |
| testdata/baselines/reference/submodule/compiler/inferTypePredicates.js | Restored isEmptyString as a type predicate (x is ""). |
| testdata/baselines/reference/submodule/compiler/inferTypePredicates.errors.txt.diff | Removed stale error entries related to filter narrowing. |
| testdata/baselines/reference/submodule/compiler/inferTypePredicates.errors.txt | Updated error count and removed obsolete errors for satisfies. |
| internal/checker/flow.go | Added ast.KindSatisfiesExpression to narrowType and reference matching. |
Comments suppressed due to low confidence (1)
testdata/baselines/reference/submodule/compiler/inferTypePredicates.types:1018
- There aren’t explicit unit tests covering nested
satisfiesexpressions for narrowing; consider adding test cases to validate both direct and nested uses ofsatisfiesin predicates.
->[1, 2, null, 3].filter( (x) => (x != null) satisfies boolean,) : number[]
jakebailey
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports microsoft/TypeScript#60782