Suggest user switching to insiders channel #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sean-mcmanus
requested changes
Feb 26, 2019
Contributor
|
Cool -- thanks a lot for this pull request. I had forgotten about this issue. |
clean code add ask me later fix errno hanlder and some typo
Contributor
|
I think @bobbrow might have had some feedback he's planning to post later. We'd like to get this in for our 0.22.0 release next week, but I don't think it will get into 0.22.0-insiders2 this week (it wouldn't be usable in an Insiders release anyway). |
bobbrow
requested changes
Feb 27, 2019
bobbrow
reviewed
Feb 27, 2019
Contributor
Author
|
I have refactored the code using |
bobbrow
requested changes
Feb 28, 2019
remove unnecessary async use 'ConfigurationTarget.Global'
bobbrow
approved these changes
Mar 1, 2019
sean-mcmanus
approved these changes
Mar 2, 2019
Contributor
|
@lh123 We'll add your credit to the changelog when we write it. |
Contributor
|
I think this change has some minor "issues" -- I'll fix them in #3251 . |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If C_Cpp.updateChannel is Default and an insiders is available, show a prompt.
fix #3089