Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix install vsix. #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sean-mcmanus merged 15 commits into from
Mar 6, 2019
Merged

Fix install vsix. #3251

sean-mcmanus merged 15 commits into from
Mar 6, 2019

Conversation

@sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus commented Mar 5, 2019 •
edited
Loading

Fix for #3206 .
Also, fixed some minor issues with #3221 .

@sean-mcmanus sean-mcmanus requested a review from a team March 5, 2019 01:22
@sean-mcmanus sean-mcmanus mentioned this pull request Mar 5, 2019
Merged
lh123
lh123 reviewed Mar 5, 2019
View reviewed changes
Copy link
Contributor

@lh123 lh123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think async function installVsix(vsixLocation: string, updateChannel: string): Promise<void>
should be function installVsix(vsixLocation: string, updateChannel: string): Promise<void>

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Mar 5, 2019

I think async function installVsix(vsixLocation: string, updateChannel: string): Promise
should be function installVsix(vsixLocation: string, updateChannel: string): Promise

Yeah, I think whoever added the async might have been confused by the linter which shows "This maybe be converted to an async function" when the async is removed -- the Quick Fix code action for that converts the .then to an await.

bobbrow
bobbrow approved these changes Mar 6, 2019
View reviewed changes
@sean-mcmanus sean-mcmanus merged commit 01d0137 into master Mar 6, 2019
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixInstallVsix branch March 6, 2019 00:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bobbrow bobbrow bobbrow approved these changes

+1 more reviewer

@lh123 lh123 lh123 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sean-mcmanus @lh123 @bobbrow