Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Resize plot to fit within pdf page #10547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2020
Merged

Resize plot to fit within pdf page #10547

merged 3 commits into from
Mar 13, 2020

Conversation

DonJayamanne
Copy link

For #9403

rchiodo
rchiodo previously approved these changes Mar 12, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo dismissed their stale review March 13, 2020 00:35

revoking review

rchiodo
rchiodo approved these changes Mar 13, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Mar 13, 2020 •
edited
Loading

Codecov Report

Merging #10547 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10547      +/-   ##
==========================================
- Coverage   60.76%   60.74%   -0.02%     
==========================================
  Files         578      578              
  Lines       31355    31355              
  Branches     4464     4464              
==========================================
- Hits        19052    19046       -6     
- Misses      11335    11339       +4     
- Partials      968      970       +2
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75% <0%> (-12.5%) ⬇️
src/client/common/utils/platform.ts 64.7% <0%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0%> (-0.73%) ⬇️
src/client/datascience/gather/gather.ts 32.81% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa6088...df72d94. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.1% 0.1% Duplication

@DonJayamanne DonJayamanne changed the title Use custom paper size if required Resize plot to fit within pdf page Mar 13, 2020
@DonJayamanne DonJayamanne merged commit 6996aaa into microsoft:master Mar 13, 2020
@DonJayamanne DonJayamanne deleted the issue9403 branch March 13, 2020 22:38
DonJayamanne added a commit that referenced this pull request Mar 17, 2020
@DonJayamanne
Merge branch 'master' into ds/custom_editor
eceea77 
* master:
  Move redux logging to a different file (#10605)
  Ensure local host only if connection not available (#10600)
  Fix a bunch of debugger issues (#10572)
  Bump acorn from 6.0.0 to 6.4.1 (#10570)
  Resize plot to fit within pdf page (#10547)
  Update dev build instructions to mention "python.insidersChannel"
  Install the ZMQ prebuilt binaries and verify ZMQ works on startup (#10551)
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo