Fix a bunch of debugger issues #10572
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
| // Make sure the last line with actual content ends with a linefeed | ||
| if (!lastLine.endsWith('\n') && lastLine.length > 0) { | ||
| stripped[stripped.length - 1] = `${lastLine}\n`; | ||
| if (!stripped[lastLinePos].endsWith('\n') && stripped[lastLinePos].length > 0) { |
There was a problem hiding this comment.
This is the only fix I can see, rest look like refactoring.
| lastLine = stripped[stripped.length - 1]; | ||
| let lastLinePos = stripped.length - 1; | ||
| let nextToLastLinePos = stripped.length - 2; | ||
| while (nextToLastLinePos > 0) { |
|
|
||
| // Call the internal method. | ||
| return this.submitCode(code, file, line); | ||
| return this.addOrDebugCode(code, file, line, false); |
There was a problem hiding this comment.
addOrDebugCode [](start = 20, length = 14)
This fixes #10395 because it 'waits' for the window to show before adding the code.
| @@ -208,7 +217,7 @@ export class HostJupyterServer extends LiveShareParticipantHost(JupyterServerBas | |||
| disposableRegistry, | |||
| this, | |||
| info, | |||
| loggers, | |||
| serviceContainer.getAll<INotebookExecutionLogger>(INotebookExecutionLogger), | |||
There was a problem hiding this comment.
getAll [](start = 33, length = 6)
This fixes #10206 because it generates new loggers for each notebook instead of having a single set for all.
There was a problem hiding this comment.
This helps a lot, eg. tomorrow one can look at a PR and understand the need for the change.. (e.g. it wasn't obvious to me). Thanks
Codecov Report
@@ Coverage Diff @@
## master #10572 +/- ##
==========================================
- Coverage 60.79% 60.77% -0.02%
==========================================
Files 579 579
Lines 31403 31412 +9
Branches 4469 4469
==========================================
Hits 19091 19091
- Misses 11342 11348 +6
- Partials 970 973 +3
Continue to review full report at Codecov.
|
* master: Move redux logging to a different file (#10605) Ensure local host only if connection not available (#10600) Fix a bunch of debugger issues (#10572) Bump acorn from 6.0.0 to 6.4.1 (#10570) Resize plot to fit within pdf page (#10547) Update dev build instructions to mention "python.insidersChannel" Install the ZMQ prebuilt binaries and verify ZMQ works on startup (#10551)
For #10395, #10396, #10206