Handle both API versions (#15932) #15936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
approved these changes
Apr 13, 2021
karthiknadig
approved these changes
Apr 13, 2021
karrtikr
approved these changes
Apr 13, 2021
karthiknadig
added a commit
that referenced
this pull request
Apr 20, 2021
* Do not run `poetry env info -p` to get the type for local poetry environment (#15898) * Do not run poetry env info -p to get the type for local poetry environment, get best effort type instead * Update src/test/pythonEnvironments/common/envlayouts/poetry/project4/pyproject.toml Co-authored-by: Karthik Nadig <[email protected]> Co-authored-by: Karthik Nadig <[email protected]> * Handle both API versions (#15932) (#15936) * Correct a news item (#15904) * Use a more forgiving comparer when comparing version (#15912) * Use a more forgiving comparer when comparing version * Update tests * Move sort interpreters function * Wrap yields with a try catch (#15931) * Log parsing errors in verbose mode only * Fix conda logging * Wrap yields with try catch * Updating the version, change-log, and TPN for release (#15989) * Update TensorBoard launcher script to not use deprecated API (#15991) Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Ian Huff <[email protected]> Co-authored-by: Joyce Er <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the fix to handle both >=1.56 API and < 1.56 API for VS Code Notebooks to release branch. This will allow python extension to release before vscode stable hits 1.56 and handle both versions.