Allow Pylance to be used with Python 2 if explicitly chosen #16210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
May 11, 2021
| @@ -200,16 +204,17 @@ suite('Python Settings', async () => { | |||
| settings.update(config.object); | |||
|
|
|||
| expect(settings.languageServer).to.be.equal(expectedValue); | |||
| expect(settings.languageServerIsDefault).to.be.equal(isDefault); | |||
There was a problem hiding this comment.
This is a basic test of the settings, but this settings test doesn't bother using IDefaultLanguageServer, which is dubious.
There was a problem hiding this comment.
configSettings needs a clean up. It has lots of minor issues that keep causing problems. We will address these when we get to that clean up.
kimadeline
approved these changes
May 11, 2021
karthiknadig
approved these changes
May 11, 2021
jakebailey
added a commit
to jakebailey/vscode-python
that referenced
this pull request
May 11, 2021
karthiknadig
pushed a commit
that referenced
this pull request
May 11, 2021
karthiknadig
added a commit
that referenced
this pull request
May 18, 2021
* Cherry-picks into release from main (#16181) * Update pygls dependency (#16165) * Upgrade all packages (#16180) * Update release version (#16196) * Update change log version * Allow Pylance to be used with Python 2 if explicitly chosen (#16210) (#16214) * Update version and change log. (#16237) * Fix Pylance Python 2 mistake (#16246) * Update version and change log for second point release Co-authored-by: Jake Bailey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #16204.
I didn't change the logic for jedi, as it will quite literally crash. Pylance doesn't need Python to run, so is safe to use (even if the analysis may not fully understand Python 2).