Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Merge release from September 6th 2019 #7274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 9, 2019
Merged

Conversation

DavidKutu
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

IanMatthewHuff and others added 7 commits August 30, 2019 13:56
* close restart session right away

* ignore errors on await, don't want to stop and wait for shutdown
* check the position of the scroll in the interactive
window, if it is at the bottom, the screen stays at the
bottom, and if not, the screen stays in place.
Throttling of the scroll was increased to help with
consistency on rapidly appearing plots.

* handle the scroll in the MainPanel, tested to work
with: - regular code, -dataframes, -big and regular plots.

* Added some comments.
checking equal to checking a range to make it work with fractions.
@codecov-io
Copy link

codecov-io commented Sep 7, 2019

Codecov Report

Merging #7274 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7274      +/-   ##
==========================================
- Coverage   58.34%   58.29%   -0.06%     
==========================================
  Files         493      493              
  Lines       21661    21661              
  Branches     3486     3486              
==========================================
- Hits        12639    12628      -11     
- Misses       8242     8255      +13     
+ Partials      780      778       -2
Impacted Files Coverage Δ
src/client/common/logger.ts 68.55% <0%> (-6.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94abff9...a70bd67. Read the comment docs.

@DavidKutu DavidKutu merged commit 02617a5 into master Sep 9, 2019
@DavidKutu DavidKutu deleted the davidkutu/merge_release branch September 9, 2019 16:14
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants