Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for Poetry environments #9399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add support for Poetry environments #9399

wants to merge 2 commits into from

Conversation

DonJayamanne
Copy link

For #8372

@DonJayamanne
Copy link
Author

@karthiknadig Will complete adding one more test and add news entry.
Else PR is ready for review.

@codecov-io
Copy link

codecov-io commented Jan 6, 2020 •
edited
Loading

Codecov Report

Merging #9399 into master will decrease coverage by 0.51%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9399      +/-   ##
==========================================
- Coverage   60.73%   60.21%   -0.52%     
==========================================
  Files         550      552       +2     
  Lines       28748    28486     -262     
  Branches     4348     4354       +6     
==========================================
- Hits        17459    17153     -306     
- Misses      10338    10376      +38     
- Partials      951      957       +6
Impacted Files Coverage Δ
src/client/interpreter/locators/index.ts 68.18% <ø> (-15.91%) ⬇️
src/client/interpreter/helpers.ts 44.73% <0%> (-0.6%) ⬇️
src/client/interpreter/contracts.ts 100% <100%> (ø) ⬆️
src/client/interpreter/serviceRegistry.ts 100% <100%> (ø) ⬆️
.../interpreter/locators/services/poetryEnvService.ts 72.72% <72.72%> (ø)
...ent/interpreter/locators/services/poetryService.ts 85.1% <85.1%> (ø)
...nt/datascience/jupyter/invalidNotebookFileError.ts 0% <0%> (-60%) ⬇️
src/client/formatters/serviceRegistry.ts 50% <0%> (-50%) ⬇️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts 33.33% <0%> (-33.34%) ⬇️
...jupyter/kernels/jupyterKernelPromiseFailedError.ts 0% <0%> (-33.34%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8d808...9d58928. Read the comment docs.

@victornoel
Copy link

@DonJayamanne @karthiknadig any news on that? :)

@DonJayamanne
Copy link
Author

Will get back to this sometime this week

@DonJayamanne DonJayamanne mentioned this pull request May 16, 2020
Closed
10 tasks
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonJayamanne @codecov-io @victornoel