test: update macro expansion test collateral #592
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates macro expansion test collateral files to match the output format of the beta Rust toolchain. The changes reflect differences in how the beta toolchain formats macro expansions compared to stable and nightly toolchains.
- Adds trailing commas to nested
format_args!macro calls in expanded macro test outputs - Updates
wdk-buildversion in test workspace'sCargo.lockfrom 0.4.0 to 0.5.1
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/wdk-macros-tests/tests/outputs/beta/macrotest/wdf_driver_create.expanded.rs |
Adds trailing comma to nested format_args! call in expanded macro output |
tests/wdk-macros-tests/tests/outputs/beta/macrotest/bug_unused_imports.expanded.rs |
Adds trailing comma to nested format_args! call in expanded macro output |
tests/customized-config-toml-workspace/Cargo.lock |
Updates wdk-build version from 0.4.0 to 0.5.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
022344c to
6795bb1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 25 25
Lines 7135 7135
Branches 7135 7135
=======================================
Hits 5899 5899
Misses 1107 1107
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
32a3a1c to
98fd300
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates the GitHub Actions workflow and makes a minor formatting change in macrotest output files.
The macrotest output was updated to align with the latest rust beta toolchain. The workflow changes were made to fix a breaking change made to Github's expression parser (likely caused be actions/languageservices#217)
Workflow improvements:
if: !cancelled()conditions toif: '!cancelled()'in.github/workflows/version-checks.yamlto ensure proper YAML parsing and consistent workflow execution for all version check steps. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Test output formatting:
format_args!macro call in generated test files for improved consistency and formatting (tests/wdk-macros-tests/tests/outputs/beta/macrotest/bug_unused_imports.expanded.rs,tests/wdk-macros-tests/tests/outputs/beta/macrotest/wdf_driver_create.expanded.rs). [1] [2]