ci: add lockfile consistency checks workflow #594
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new GitHub Actions workflow to verify the consistency of Cargo.lock files across the repository. The workflow discovers all tracked Cargo.lock files, then validates each one by running cargo update --workspace --locked to ensure lockfiles are in sync with their respective Cargo.toml manifests.
Key Changes:
- New workflow that dynamically discovers and validates multiple Cargo.lock files
- Uses a matrix strategy to check each lockfile in parallel
- Includes a summarization job to report overall success/failure
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/lockfile-checks.yaml | New workflow with three jobs: discovers Cargo.lock files, validates each with --locked flag, and summarizes results |
| tests/wdk-macros-tests/tests/outputs/beta/macrotest/wdf_driver_create.expanded.rs | Added trailing comma to format_args! call (auto-generated macro expansion output) |
| tests/wdk-macros-tests/tests/outputs/beta/macrotest/bug_unused_imports.expanded.rs | Added trailing comma to format_args! call (auto-generated macro expansion output) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Run cargo update --workspace --locked | ||
| shell: bash | ||
| run: | | ||
| set -u | ||
|
|
||
| lockfile='${{ matrix.lockfile }}' | ||
| dir=$(dirname "$lockfile") | ||
|
|
||
| echo "Running cargo update --workspace --locked for $lockfile" | ||
| pushd "$dir" > /dev/null | ||
| cargo update --workspace --locked | ||
| popd > /dev/null |
There was a problem hiding this comment.
The cargo command is being executed without installing a Rust toolchain first. The job needs to install Rust (using an action like dtolnay/rust-toolchain) before running cargo commands. Without this step, the cargo command will fail because cargo won't be available in the runner environment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 25 25
Lines 7135 7135
Branches 7135 7135
=======================================
Hits 5899 5899
Misses 1107 1107
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blocked on #592