LGTM

TestResizeApiResponse should have failed without this PR, but instead passed. It might be related to the fact that the container exited (since it's just a docker run -d busybox true)

I guess we'll fix that in another PR :)

It threw me off a bit, it should have failed at least once if that is a
timing issue. I could not see failure in my 5 - 6 time I ran the test. I
understand your point. Let me try to make it fail.

From: Tibor Vass [email protected]
To: docker/docker [email protected]
Cc: Srinivas R Brahmaroutu/Silicon Valley/IBM@IBMUS
Date: 10/23/2014 05:34 PM
Subject: Re: [docker] Allowing resize tty to only work when container is
started (#8737)

I guess we'll fix that in another PR :)

—
Reply to this email directly or view it on GitHub.

I apologize, I fixed the issue and I realized I should also fix the docs. I created a new PR #8749