Codestin Search App

brahmaroutu · 2014-10-24T04:41:17Z

Addresses #8728

Signed-off-by: Srini Brahmaroutu [email protected]

tiborvass · 2014-10-24T20:51:14Z

brahmaroutu · 2014-10-24T21:43:34Z

Changed the Test as per the comments.

SvenDowideit · 2014-10-29T02:02:12Z

LGTM - @fredlf @jamtur01

SvenDowideit · 2014-10-29T02:02:41Z

do you mean The container must be restarted for the resize to take effect. ?

Can you please revise this as @SvenDowideit has suggested? The original sentence is unclear.

jamtur01 · 2014-10-29T02:05:20Z

LGTM I guess.

brahmaroutu · 2014-10-29T02:16:19Z

Yes that is correct, Fix provided will make sure container is running for resize to work.

fredlf · 2014-11-03T17:11:52Z

fredlf · 2014-11-03T17:12:40Z

Needs revision as suggested in line. Thanks.

brahmaroutu · 2014-11-03T18:25:26Z

@fredlf Based on @SvenDowideit comments, I think I changed the text indicating container must be started before issuing resize. Do you mean that we should expand that further?

fredlf · 2014-11-03T19:10:12Z

I mean that the sentence "Container must be started before resize is requested" is not very clear and will confuse readers, so it should be revised along the lines of Sven's suggestion: "The container must be restarted for the resize to take effect." Thanks.

brahmaroutu · 2014-11-03T19:27:04Z

Thanks, fixed.

tiborvass · 2014-11-03T19:46:14Z

LGTM for the test change
Ping @vieux @jfrazelle

jessfraz · 2014-11-03T19:49:47Z

LGTM

unclejack · 2014-11-14T14:13:40Z

LGTM

@vieux PTAL

tiborvass · 2014-11-15T18:46:57Z

@brahmaroutu this actually should be POST /containers/(id)/resize. Sorry for late review!

brahmaroutu · 2014-11-17T16:41:39Z

Thanks @tiborvass, good catch, fixed it now.

tiborvass · 2014-11-17T16:45:21Z

I'm not sure how the API docs work, @vieux @jfrazelle @fredlf @SvenDowideit , but why is it only in 1.9 and 1.15 and not the versions in between?

@brahmaroutu Also, just realized, you would also need to make the change for 1.16 (the next version).

jamtur01 · 2014-11-17T16:48:52Z

@tiborvass I'd say that'd be an oversight.

brahmaroutu · 2014-11-17T16:55:53Z

I have the same confusion, I should only add it to the last version and that used to be 1.15. I now moved the changes to 1.16. Let me know if this looks good?

jessfraz · 2014-11-17T17:19:03Z

I don't think it needs to be in 1.9?

tiborvass · 2014-11-17T17:20:07Z

@jfrazelle what's more confusing is if you do a grep -r '/resize' docs/

jessfraz · 2014-11-17T17:23:11Z

oh dear... was that even a part of 1.9, when did that get added

jessfraz · 2014-11-17T17:24:36Z

@brahmaroutu can you delete resize entirely from the 1.9 docs c7f3fdc looks like it shouldnt be there at all

brahmaroutu · 2014-11-17T18:06:27Z

Did remove change to 1.9. Let me know if this is good now?

jessfraz · 2014-11-17T18:33:13Z

@brahmaroutu sorry that was poor wording on my part, the resize endpoint should not even be included in the 1.9 docs. Please remove it completely.

Closes moby#8728 Signed-off-by: Srini Brahmaroutu <[email protected]>

brahmaroutu · 2014-11-17T18:41:14Z

@jfrazelle It was more of my concern and tendency to restore 1.9 to it original state. Anyways I removed resize from 1.9 and I am assuming 1.9 is 1.09 when resize did not exist. Sorry.

jessfraz · 2014-11-17T18:52:45Z

perfect thank you :) LGTM

SvenDowideit · 2014-11-18T01:24:55Z

this has the needed reviews - thank you all for the many fixes!

Fix the documentation and integration test for container resize

brahmaroutu mentioned this pull request Oct 24, 2014

Allowing resize tty to only work when container is started #8737

Merged

jessfraz added the /project/doc label Oct 24, 2014

tiborvass reviewed Oct 24, 2014
View reviewed changes

Comment thread integration-cli/docker_api_resize_test.go Outdated

tiborvass Oct 24, 2014

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use top

brahmaroutu force-pushed the resize_uponstart_8728_2 branch from 5e18f55 to fb31772 Compare October 24, 2014 21:29

SvenDowideit reviewed Oct 29, 2014
View reviewed changes

fredlf reviewed Nov 3, 2014
View reviewed changes

Comment thread docs/sources/reference/api/docker_remote_api_v1.9.md Outdated

fredlf Nov 3, 2014

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

brahmaroutu force-pushed the resize_uponstart_8728_2 branch from fb31772 to 31a75dd Compare November 3, 2014 19:16

brahmaroutu force-pushed the resize_uponstart_8728_2 branch from 31a75dd to 0c59f5c Compare November 3, 2014 20:58

brahmaroutu force-pushed the resize_uponstart_8728_2 branch from 0c59f5c to 72d6954 Compare November 11, 2014 16:14

tiborvass reviewed Nov 15, 2014
View reviewed changes

brahmaroutu force-pushed the resize_uponstart_8728_2 branch from 72d6954 to 10f9335 Compare November 17, 2014 16:40

brahmaroutu force-pushed the resize_uponstart_8728_2 branch from 10f9335 to 50fb2f6 Compare November 17, 2014 16:54

brahmaroutu force-pushed the resize_uponstart_8728_2 branch from 50fb2f6 to 6b94796 Compare November 17, 2014 18:05

Fix the documentation and integration test for container resize

91fb9b2

Closes moby#8728 Signed-off-by: Srini Brahmaroutu <[email protected]>

brahmaroutu force-pushed the resize_uponstart_8728_2 branch from 6b94796 to 91fb9b2 Compare November 17, 2014 18:38

SvenDowideit added a commit that referenced this pull request Nov 18, 2014

Merge pull request #8749 from brahmaroutu/resize_uponstart_8728_2

e2d08bd

Fix the documentation and integration test for container resize

SvenDowideit merged commit e2d08bd into moby:master Nov 18, 2014

brahmaroutu deleted the resize_uponstart_8728_2 branch November 26, 2014 23:25

Uh oh!

Conversation

brahmaroutu commented Oct 24, 2014

Uh oh!

tiborvass Oct 24, 2014

Choose a reason for hiding this comment

Uh oh!

brahmaroutu commented Oct 24, 2014

Uh oh!

SvenDowideit commented Oct 29, 2014

Uh oh!

SvenDowideit Oct 29, 2014

Choose a reason for hiding this comment

Uh oh!

fredlf Nov 3, 2014

Choose a reason for hiding this comment

Uh oh!

jamtur01 commented Oct 29, 2014

Uh oh!

brahmaroutu commented Oct 29, 2014

Uh oh!

fredlf Nov 3, 2014

Choose a reason for hiding this comment

Uh oh!

fredlf commented Nov 3, 2014

Uh oh!

brahmaroutu commented Nov 3, 2014

Uh oh!

fredlf commented Nov 3, 2014

Uh oh!

brahmaroutu commented Nov 3, 2014

Uh oh!

tiborvass commented Nov 3, 2014

Uh oh!

jessfraz commented Nov 3, 2014

Uh oh!

unclejack commented Nov 14, 2014

Uh oh!

tiborvass Nov 15, 2014

Choose a reason for hiding this comment

Uh oh!

brahmaroutu commented Nov 17, 2014

Uh oh!

tiborvass commented Nov 17, 2014

Uh oh!

jamtur01 commented Nov 17, 2014

Uh oh!

brahmaroutu commented Nov 17, 2014

Uh oh!

jessfraz commented Nov 17, 2014

Uh oh!

tiborvass commented Nov 17, 2014

Uh oh!

jessfraz commented Nov 17, 2014

Uh oh!

jessfraz commented Nov 17, 2014

Uh oh!

brahmaroutu commented Nov 17, 2014

Uh oh!

jessfraz commented Nov 17, 2014

Uh oh!

brahmaroutu commented Nov 17, 2014

Uh oh!

jessfraz commented Nov 17, 2014

Uh oh!

SvenDowideit commented Nov 18, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants