Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Tweaks to Dockerfile tutorial#8762

Merged
jamtur01 merged 2 commits into
moby:masterfrom
fredlf:tutorial-tweaks
Oct 29, 2014
Merged

Tweaks to Dockerfile tutorial#8762
jamtur01 merged 2 commits into
moby:masterfrom
fredlf:tutorial-tweaks

Conversation

@fredlf

@fredlf fredlf commented Oct 24, 2014

Copy link
Copy Markdown
Contributor

Made a few tweaks to Dockerfile tutorial links and removed some cruft from the tutorial itself.

Docker-DCO-1.1-Signed-off-by: Fred Lifton [email protected] (github: fredlf)

Made a few tweaks to Dockerfile tutorial links and removed some cruft from the tutorial itself.

Docker-DCO-1.1-Signed-off-by: Fred Lifton <[email protected]> (github: fredlf)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace with https://docs.docker.com/articles/dockerfile_best-practices/ in stead of removing entirely?

(hm, seeing that link, why does that contain an underscore?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's a good, and embarrassingly obvious, idea. I'll change it.

Is there a problem with underscores in links I don't know about? I probably did that out of the habit of using underscores for spaces in file names in the olden days.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a huge problem, but from a SEO perspective, dashes are preferred over underscores;
http://blog.woorank.com/2013/04/underscores-in-urls-why-are-they-not-recommended/
https://support.google.com/webmasters/answer/76329?hl=en

In this case, I think it's a bit inconsistent because both underscores and a dash is used

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Well I learned something today. Pretty classic engineer vs. writer perspective. I think of the marks semantically, like a writer; that is, hyphens connect words together and spaces (as represented by underscores) are used to separate words (which is why I don't see that filename as inconsistent). Engineers (like the Google engineer in the first link), see hyphens as separators and underscores as, essentially, null. Very interesting (to someone like me, YMMV). I reckon I'll avoid underscores in URL's in the future, even though it chaps my hide to have engineers define interpretive behavior! :-)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, yes technology and grammar can conflict 😄

In Docker's case, I seriously doubt you'll have trouble getting top rankings on Google, so probably not a huge point. Perhaps something to add to the docs-guidelines, just for good measure.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @fredlf reading this back; Is this on your todo list for the documentation guid? (The technical version)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaJeztah Yes, it's on my backlog. When it makes it off the backlog is another question entirely. :-)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredlf no problem, just making sure, because this PR was merged, it's easy to lose sight :)

Docker-DCO-1.1-Signed-off-by: Fred Lifton <[email protected]> (github: fredlf)
@fredlf

fredlf commented Oct 24, 2014

Copy link
Copy Markdown
Contributor Author

Sorry for the multiple commits. I'm getting a git bug with rebasing (it hangs in the middle) that I haven't tracked down yet.

@SvenDowideit

Copy link
Copy Markdown
Contributor

LGTM - with rebase :) @jamtur01

jamtur01 added a commit that referenced this pull request Oct 29, 2014
@jamtur01 jamtur01 merged commit 01454a5 into moby:master Oct 29, 2014
SvenDowideit pushed a commit to SvenDowideit/docker that referenced this pull request Nov 6, 2014
Tweaks to Dockerfile tutorial
(cherry picked from commit 01454a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants