Tweaks to Dockerfile tutorial#8762
Conversation
Made a few tweaks to Dockerfile tutorial links and removed some cruft from the tutorial itself. Docker-DCO-1.1-Signed-off-by: Fred Lifton <[email protected]> (github: fredlf)
There was a problem hiding this comment.
Maybe replace with https://docs.docker.com/articles/dockerfile_best-practices/ in stead of removing entirely?
(hm, seeing that link, why does that contain an underscore?)
There was a problem hiding this comment.
Oh, that's a good, and embarrassingly obvious, idea. I'll change it.
Is there a problem with underscores in links I don't know about? I probably did that out of the habit of using underscores for spaces in file names in the olden days.
There was a problem hiding this comment.
not a huge problem, but from a SEO perspective, dashes are preferred over underscores;
http://blog.woorank.com/2013/04/underscores-in-urls-why-are-they-not-recommended/
https://support.google.com/webmasters/answer/76329?hl=en
In this case, I think it's a bit inconsistent because both underscores and a dash is used
There was a problem hiding this comment.
Huh. Well I learned something today. Pretty classic engineer vs. writer perspective. I think of the marks semantically, like a writer; that is, hyphens connect words together and spaces (as represented by underscores) are used to separate words (which is why I don't see that filename as inconsistent). Engineers (like the Google engineer in the first link), see hyphens as separators and underscores as, essentially, null. Very interesting (to someone like me, YMMV). I reckon I'll avoid underscores in URL's in the future, even though it chaps my hide to have engineers define interpretive behavior! :-)
There was a problem hiding this comment.
Hehe, yes technology and grammar can conflict 😄
In Docker's case, I seriously doubt you'll have trouble getting top rankings on Google, so probably not a huge point. Perhaps something to add to the docs-guidelines, just for good measure.
There was a problem hiding this comment.
Ping @fredlf reading this back; Is this on your todo list for the documentation guid? (The technical version)?
There was a problem hiding this comment.
@thaJeztah Yes, it's on my backlog. When it makes it off the backlog is another question entirely. :-)
There was a problem hiding this comment.
@fredlf no problem, just making sure, because this PR was merged, it's easy to lose sight :)
Docker-DCO-1.1-Signed-off-by: Fred Lifton <[email protected]> (github: fredlf)
|
Sorry for the multiple commits. I'm getting a git bug with rebasing (it hangs in the middle) that I haven't tracked down yet. |
|
LGTM - with rebase :) @jamtur01 |
Tweaks to Dockerfile tutorial
Tweaks to Dockerfile tutorial (cherry picked from commit 01454a5)
Made a few tweaks to Dockerfile tutorial links and removed some cruft from the tutorial itself.
Docker-DCO-1.1-Signed-off-by: Fred Lifton [email protected] (github: fredlf)