Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sreenaths
Copy link
Contributor

@sreenaths sreenaths commented Aug 5, 2025

The instance variable notification_options was being instantiated and
initialized in Server init, but was never used. Instead, a fresh
notification_options object is accepted as an argument in
create_initialization_options and get_capabilities.
This PR removes the unused instance variable.

Motivation and Context

This removes confusion about the use of notification_options in the server.

How Has This Been Tested?

Existing tests work as expected

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

None

@sreenaths sreenaths requested a review from a team as a code owner August 5, 2025 05:23
@sreenaths sreenaths requested a review from ochafik August 5, 2025 05:23
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@domdomegg domdomegg merged commit 34e3664 into modelcontextprotocol:main Aug 5, 2025
10 checks passed
@sreenaths
Copy link
Contributor Author

Thank you @domdomegg

@sreenaths sreenaths deleted the remove-unused-variable branch August 5, 2025 15:06
saqadri pushed a commit to saqadri/stdio-fixes that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants