Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: apply a few pylint rules (via ruff)#2587

Merged
wpbonelli merged 2 commits into
modflowpy:developfrom
mwtoews:ruff-pylint
Sep 4, 2025
Merged

refactor: apply a few pylint rules (via ruff)#2587
wpbonelli merged 2 commits into
modflowpy:developfrom
mwtoews:ruff-pylint

Conversation

@mwtoews

@mwtoews mwtoews commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

This applies a few sets of Pylint rules available with Ruff:

@codecov

codecov Bot commented Sep 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.22378% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.5%. Comparing base (556c088) to head (afc9a2f).
⚠️ Report is 39 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/mfreadnam.py 0.0% 7 Missing ⚠️
flopy/plot/plotutil.py 25.0% 6 Missing ⚠️
flopy/utils/zonbud.py 60.0% 6 Missing ⚠️
flopy/utils/util_list.py 44.4% 5 Missing ⚠️
flopy/utils/parse_version.py 0.0% 2 Missing ⚠️
flopy/discretization/modeltime.py 50.0% 1 Missing ⚠️
flopy/export/netcdf.py 50.0% 1 Missing ⚠️
flopy/export/vtk.py 83.3% 1 Missing ⚠️
flopy/modflow/mffhb.py 50.0% 1 Missing ⚠️
flopy/modflow/mfmnw2.py 0.0% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2587      +/-   ##
===========================================
+ Coverage     55.5%    72.5%   +16.9%     
===========================================
  Files          644      667      +23     
  Lines       124135   128603    +4468     
===========================================
+ Hits         68947    93250   +24303     
+ Misses       55188    35353   -19835     
Files with missing lines Coverage Δ
flopy/__init__.py 100.0% <ø> (ø)
flopy/mf6/coordinates/simulationtime.py 52.7% <100.0%> (-1.3%) ⬇️
flopy/mf6/utils/model_splitter.py 65.0% <100.0%> (-9.9%) ⬇️
flopy/mfusg/mfusg.py 78.1% <100.0%> (+0.6%) ⬆️
flopy/mfusg/mfusgbcf.py 85.0% <100.0%> (+4.5%) ⬆️
flopy/mfusg/mfusgbct.py 85.9% <100.0%> (ø)
flopy/mfusg/mfusglpf.py 75.0% <100.0%> (-5.4%) ⬇️
flopy/mfusg/mfusgoc.py 59.9% <ø> (ø)
flopy/modflow/mfag.py 91.1% <100.0%> (ø)
flopy/modflow/mfhfb.py 89.1% <ø> (+4.7%) ⬆️
... and 32 more

... and 388 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli merged commit 291fa8e into modflowpy:develop Sep 4, 2025
20 checks passed
@mwtoews mwtoews deleted the ruff-pylint branch September 4, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants