Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Compile only on Gradle API and Kotlin stdlib#20

Merged
Rawa merged 1 commit into
mullvad:mainfrom
Goooler:compile-only-on-kotlin-and-gradle
May 19, 2026
Merged

Compile only on Gradle API and Kotlin stdlib#20
Rawa merged 1 commit into
mullvad:mainfrom
Goooler:compile-only-on-kotlin-and-gradle

Conversation

@Goooler
Copy link
Copy Markdown
Contributor

@Goooler Goooler commented May 13, 2026

They should be depended on by compileOnly instead of implementation.

diff --color=auto -r old/plugin/0.10.1/plugin-0.10.1.module new/plugin/0.10.1/plugin-0.10.1.module
28,36d27
<       "dependencies": [
<         {
<           "group": "org.jetbrains.kotlin",
<           "module": "kotlin-stdlib",
<           "version": {
<             "requires": "2.3.21"
<           }
<         }
<       ],
66,72d56
<           }
<         },
<         {
<           "group": "org.jetbrains.kotlin",
<           "module": "kotlin-stdlib",
<           "version": {
<             "requires": "2.3.21"
diff --color=auto -r old/plugin/0.10.1/plugin-0.10.1.pom new/plugin/0.10.1/plugin-0.10.1.pom
14,19d13
<       <groupId>org.jetbrains.kotlin</groupId>
<       <artifactId>kotlin-stdlib</artifactId>
<       <version>2.3.21</version>
<       <scope>compile</scope>
<     </dependency>
<     <dependency>
diff --color=auto -r old/plugin/maven-metadata-local.xml new/plugin/maven-metadata-local.xml
11c11
<     <lastUpdated>20260513100445</lastUpdated>
---
>     <lastUpdated>20260513100638</lastUpdated>
diff --color=auto -r old/rust-android/net.mullvad.rust-android.gradle.plugin/maven-metadata-local.xml new/rust-android/net.mullvad.rust-android.gradle.plugin/maven-metadata-local.xml
11c11
<     <lastUpdated>20260513100438</lastUpdated>
---
>     <lastUpdated>20260513100637</lastUpdated>

This change is Reviewable

They should be depended on by `compileOnly` instead of `implementation`.

```diff
diff --color=auto -r old/plugin/0.10.1/plugin-0.10.1.module new/plugin/0.10.1/plugin-0.10.1.module
28,36d27
<       "dependencies": [
<         {
<           "group": "org.jetbrains.kotlin",
<           "module": "kotlin-stdlib",
<           "version": {
<             "requires": "2.3.21"
<           }
<         }
<       ],
66,72d56
<           }
<         },
<         {
<           "group": "org.jetbrains.kotlin",
<           "module": "kotlin-stdlib",
<           "version": {
<             "requires": "2.3.21"
diff --color=auto -r old/plugin/0.10.1/plugin-0.10.1.pom new/plugin/0.10.1/plugin-0.10.1.pom
14,19d13
<       <groupId>org.jetbrains.kotlin</groupId>
<       <artifactId>kotlin-stdlib</artifactId>
<       <version>2.3.21</version>
<       <scope>compile</scope>
<     </dependency>
<     <dependency>
diff --color=auto -r old/plugin/maven-metadata-local.xml new/plugin/maven-metadata-local.xml
11c11
<     <lastUpdated>20260513100445</lastUpdated>
---
>     <lastUpdated>20260513100638</lastUpdated>
diff --color=auto -r old/rust-android/net.mullvad.rust-android.gradle.plugin/maven-metadata-local.xml new/rust-android/net.mullvad.rust-android.gradle.plugin/maven-metadata-local.xml
11c11
<     <lastUpdated>20260513100438</lastUpdated>
---
>     <lastUpdated>20260513100637</lastUpdated>
```
Copy link
Copy Markdown
Collaborator

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me

@Rawa Rawa merged commit 3f4c901 into mullvad:main May 19, 2026
17 of 18 checks passed
@Goooler Goooler deleted the compile-only-on-kotlin-and-gradle branch May 19, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants