fix(runtime): reject array helper-status files; dedupe isRecord - #544

Summary

Fixes the bug surfaced by #543's coverage work: the local isRecord copy in lib/runtime/runtime-current-account.ts had drifted from the canonical lib/utils.ts guard and accepted JSON arrays, so an [] helper-status file produced an all-null status object instead of null. Harmless today only because the downstream kind check happened to reject the all-null object — but it's exactly the class of silent drift the canonical guard exists to prevent.

Stacked on #543 (which pinned the buggy behavior with a test) — merge that first; this PR then shows only the fix commit.

Changes

• Deletes the drifted local isRecord duplicate; imports the canonical isRecord from lib/utils.js (which already does !Array.isArray(value)). No cycle risk — utils is a leaf.
• Flips test(lib): cover the highest-value gaps in four logic modules #543's behavior-pinning test to the corrected contract: an [] helper-status file now reads as null (malformed content), not an all-null record.

Note for a future sweep: four more files carry local isRecord copies (commands/rotation.ts, codex-cli/writer.ts, codex-cli/state.ts, plus one in recovery) — each needs its own semantics check before deduping, so they're deliberately out of scope here.

Validation

• npm run typecheck; eslint --max-warnings=0
• runtime-current-account suite 17/17 with the corrected expectation; proxy safe-equal + issue-474 + app-router canaries pass

Risk / Rollback

One guard tightened to match the canonical implementation; revert the single commit. Behavior change is strictly: malformed array status files are now rejected at read time instead of one step later.

https://claude.ai/code/session_01XNtnkLbBiXZxfQQYLMpucB

Generated by Claude Code

note: greptile review for oc-chatgpt-multi-auth. cite files like lib/foo.ts:123. confirm regression tests + windows concurrency/token redaction coverage.

Greptile Summary

replaces the drifted local isRecord copy in runtime-current-account.ts with the canonical import from lib/utils.ts, which correctly excludes arrays via !Array.isArray(value). this closes the silent gap where a [] status file produced an all-null object instead of null.

• core fix: one-line import swap in runtime-current-account.ts — the local duplicate is deleted and the canonical guard takes over, so array-shaped status files are now rejected at the isRecord boundary rather than one step later by the kind check.
• test coverage: test/runtime-current-account.test.ts gets a full readAppRuntimeHelperStatus suite including the array-rejection regression case; test/snapshot-inspectors.test.ts is a new file that uses the canonical isRecord import in createDeps (addressing the previous review comment), and two other test files gain additional command-level coverage.
• windows safety: all new test cleanup paths use removeWithRetry, consistent with the project convention.

Confidence Score: 5/5

safe to merge — a one-import swap tightening a guard on an untrusted filesystem read, with a direct regression test covering the corrected behavior

the change is minimal and targeted: the local isRecord copy is deleted, the canonical version (which adds !Array.isArray) is imported, and the new test explicitly asserts that an array status file now returns null. no logic paths beyond the guard change are touched, and downstream consumers of readAppRuntimeHelperStatus are unaffected because the stricter guard only rejects already-malformed input.

no files require special attention — all changed files are straightforward

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[readAppRuntimeHelperStatus] --> B{file exists?}
    B -- no --> Z1[return null]
    B -- yes --> C{size > 1 MB?}
    C -- yes --> Z2[return null]
    C -- no --> D[JSON.parse file]
    D --> E{isRecord check}
    E -- before fix: typeof===object && !==null\naccepts arrays --> F_OLD[array → all-null status object]
    E -- after fix: canonical isRecord\n!Array.isArray added --> F_NEW[array → return null]
    F_OLD --> G[downstream kind check rejects]
    F_NEW --> Z3[return null early]
    E -- plain object --> H[build AppRuntimeHelperAccountStatus]
    H --> I[return normalized status]

_{Reviews (2): Last reviewed commit: "Merge branch 'claude/audit-25-coverage-g..." | Re-trigger Greptile}