refactor(lib): dedupe drifted isRecord guards into the canonical utils helper - #545

Summary

Sweep follow-up to #544 (which fixed a real bug caused by a drifted local isRecord). This PR audits all nine local isRecord definitions under lib/ and dedupes the two that drifted from the canonical array-rejecting contract in lib/utils.ts:

• lib/codex-manager/commands/rotation.ts — local guard (typeof value === "object" && value !== null) used when parsing the app runtime helper status file; replaced with import { isRecord } from "../../utils.js".
• lib/refresh-lease.ts — local guard (value !== null && typeof value === "object") used in parseLeasePayload / parseResultPayload; replaced with import { isRecord } from "./utils.js".

Unlike #544, the drift here was latent: downstream per-field validation already produced all-null/invalid results for array payloads, so there is no observable behavior change — this is dedupe plus hardening against the same silent-drift bug class. The six remaining local copies already match the canonical semantics (reject arrays) and are deliberately left in place.

Changes

• Delete the two drifted local isRecord definitions; import the canonical helper instead.
• test/refresh-lease.test.ts: new test pinning that an array result file never makes a caller a follower, and an array lock file is an invalid payload (never owned, never treated stale — acquire times out to bypass without deleting it).
• test/codex-manager-rotation-command.test.ts: new test pinning that an array helper status file reads as "Codex app helper: not running" rather than a record with all-null fields.

Validation

• npm run typecheck clean
• npx eslint on all four touched files, --max-warnings=0
• npx vitest run test/refresh-lease.test.ts test/codex-manager-rotation-command.test.ts — 51/51 passed (49 pre-existing + 2 new)

Risk / Rollback

Low: zero observable behavior change (array payloads were already rejected by field-level checks); the canonical guard is strictly narrower. Independent of #543/#544 (no overlapping files); based on main. Rollback = revert the single commit.

https://claude.ai/code/session_01XNtnkLbBiXZxfQQYLMpucB

Generated by Claude Code

note: greptile review for oc-chatgpt-multi-auth. cite files like lib/foo.ts:123. confirm regression tests + windows concurrency/token redaction coverage.

Greptile Summary

dedupes two drifted local isRecord guards in lib/refresh-lease.ts and lib/codex-manager/commands/rotation.ts by importing the canonical array-rejecting helper from lib/utils.ts, and adds regression tests pinning that array JSON payloads are correctly rejected in both files.

• lib/refresh-lease.ts: removes value !== null && typeof value === \"object\" local guard; canonical guard adds !Array.isArray(value), preventing arrays from being silently parsed as lease/result records with all-null fields.
• lib/codex-manager/commands/rotation.ts: same removal; array status files now correctly return null from readAppRuntimeHelperStatus instead of a record with every field null.
• two new vitest tests pin the expected behavior for array payloads in both modules, following established test patterns.

Confidence Score: 4/5

changes to the two targeted files are correct and well-tested; a third drifted guard in runtime-current-account.ts reads the same status file and was not fixed

the audit claimed to cover all nine local copies, but lib/runtime/runtime-current-account.ts line 101 still has the array-accepting form (typeof value === 'object' && value !== null) in its own readAppRuntimeHelperStatus — the same read path the rotation.ts fix covers — leaving the latent drift alive in a parallel code path

lib/runtime/runtime-current-account.ts — local isRecord at line 100 is missing !Array.isArray(value)

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[JSON file on disk] --> B{JSON.parse}
    B --> C[isRecord check]
    C -- "old: typeof obj && !== null\n(arrays pass!)" --> D[field-level validation\nall fields null]
    C -- "new: canonical utils.isRecord\n(arrays rejected)" --> E[return null\nearly exit]
    D --> F[caller sees all-null struct\nsilent bad state]
    E --> G[caller sees null\ncorrect not-running / invalid]

_{Reviews (1): Last reviewed commit: "refactor(lib): dedupe drifted isRecord g..." | Re-trigger Greptile}