ci: fix MCP Registry publishing workflow #21342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds GitHub OIDC authentication to the MCP Registry publishing workflow to fix the failing "Validate server.json" step. The workflow previously relied on GITHUB_TOKEN, but mcp-publisher requires explicit authentication via github-oidc login.
Key Changes:
- Added new authentication step using
mcp-publisher login github-oidcbefore validation and publishing operations - Leverages existing
id-token: writepermission already configured in the workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Ferroin
approved these changes
Nov 22, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Dec 2, 2025
(cherry picked from commit 73d4223)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Dec 3, 2025
(cherry picked from commit 73d4223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix MCP publisher login
The workflow previously failed during the validation step because mcp-publisher requires explicit authentication.
Added:
This allows both dry-run and publish steps to authenticate using GitHub OIDC.
Allow manual execution
Added workflow_dispatch so the workflow can be triggered manually from the GitHub UI.
Prevent accidental manual runs on non-tag refs
Added a guard step that aborts workflow_dispatch runs unless the workflow is triggered on a tag starting with v.
This ensures manual executions behave consistently with release-triggered runs.
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Authenticate mcp-publisher via GitHub OIDC in the Update MCP Registry workflow to fix the failing Validate server.json step and unblock dry-run/publish. Also allow manual runs, limited to v* tags.
Bug Fixes
New Features
Written for commit 63e2521. Summary will update automatically on new commits.