Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Dec 1, 2025

Summary
  1. Replace dots with slashes in OTEL metric families for hierarchical grouping (Replace dots with slashes in OTEL metric families for hierarchical grouping #21371)
  2. Remove retention check during datafile initialization (Remove retention check during datafile initialization #21387)
  3. fix(go.d): prefer env-provided dirs over build-time defaults (fix(go.d): prefer env-provided dirs over build-time defaults #21345)
  4. chore(go.d): disable redis lib logging (chore(go.d): disable redis lib logging #21344)
  5. ci: fix MCP Registry publishing workflow (ci: fix MCP Registry publishing workflow #21342)
  6. Adjust windows sensors initialization (Adjust windows sensors initialization #21374)
  7. fix(docker): fix bugs and refactor Docker entrypoint script (fix(docker): fix bugs and refactor Docker entrypoint script #21364)
  8. add netdata user to video group (add netdata user to video group #21359)
  9. fix(docker): add netdata user to nvidia device group on non-Debian systems (fix(docker): add netdata user to nvidia device group on non-Debian systems #21358)
  10. Improve stale replication (Improve stale replication #21357)
  11. Improve replication logic by checking if parent is caught up with child (Improve replication logic by checking if parent is caught up with child #21352)

Summary by cubic

Improves replication reliability and prevents data loss. Also fixes Docker GPU group assignment and Windows sensors initialization.

  • Bug Fixes
    • Receiver: finish replication when the parent’s last entry is at or ahead of the child’s.
    • Receiver: detect and break stuck loops using a per-chart counter; reset on valid data or when streaming starts.
    • Sender: on buffer overflow, set enable_streaming=false to avoid truncating intervals and losing data.
    • Sender: if a chart is missing, send an empty REPLAY_END with start_streaming=true to unblock the parent.
    • Docker/packaging: add netdata user to video/NVIDIA device groups (GID-based) and refactor entrypoint for safer group assignment, telemetry flags, and sane defaults.
    • Windows: initialize COM in the sensor thread and manage ISensorManager there to prevent startup issues.

Written for commit 3daab5e. Summary will update automatically on new commits.

* Implement stuck replication detection and response handling

* Fix checks and commit response for not found chart

* Initialize replication stuck detection counter and refine replication completion conditions

* Refine streaming response handling to prevent data loss during buffer overflow

(cherry picked from commit c643895)
@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Dec 1, 2025
* Chaneg sensor initialization to handle COM setup in the sensor thread

* Fix COM initialization handling in sensor thread

(cherry picked from commit a87d38e)
@github-actions github-actions bot added area/collectors Everything related to data collection collectors/windows labels Dec 1, 2025
stelfrag and others added 2 commits December 3, 2025 11:16
…ouping (netdata#21371)

Co-authored-by: ilyam8 <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
(cherry picked from commit d7f3bf3)
@Ferroin Ferroin marked this pull request as ready for review December 3, 2025 13:18
@Ferroin Ferroin merged commit b299c50 into netdata:v2.8 Dec 3, 2025
111 of 112 checks passed
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 15 files

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/update-mcp-registry.yml">

<violation number="1" location=".github/workflows/update-mcp-registry.yml:26">
P2: Potential script injection: `${{ github.ref }}` is directly interpolated in the shell script. Use an intermediate environment variable to prevent malicious branch names from executing arbitrary commands.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@stelfrag stelfrag deleted the patch_release branch December 4, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants