chore(deps-dev): bump @vitest/eslint-plugin to 1.3.20 (supersedes #7701)#8305
Open
jherr wants to merge 2 commits into
Open
chore(deps-dev): bump @vitest/eslint-plugin to 1.3.20 (supersedes #7701)#8305jherr wants to merge 2 commits into
jherr wants to merge 2 commits into
Conversation
Applies the intent of #7701 directly on top of main instead of merging that stale branch, which would have downgraded vitest to 3.2.4. The ^8.46.1 @typescript-eslint dependency resolves as a nested subtree, so the top-level typescript-eslint stack stays at 8.45.0 and vitest at 3.2.4. No .npmrc needed. 1.3.20 enables the prefer-called-exactly-once-with rule; the flagged test assertions are collapsed into toHaveBeenCalledExactlyOnceWith via eslint --fix + prettier. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Couldn't analyze Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Benchmark resultsComparing with 77982eb
|
jaredm563
approved these changes
Jun 16, 2026
khendrikse
pushed a commit
that referenced
this pull request
Jun 17, 2026
Combines three open dependency-bump PRs into one branch, plus the one code fix the bumps require. ## Included | Source PR | Change | |-----------|--------| | #8297 | shell-quote 1.8.3 → 1.8.4 (transitive) | | #8242 | fast-uri 3.1.0 → 3.1.2 (transitive) | | #8299 | @netlify/build → 35.15.0, @netlify/zip-it-and-ship-it → 14.7.1 | ## Required follow-on fix - **`netlify-function.ts`**: removed a now-obsolete `@ts-expect-error`. The @netlify/build bump ships the updated `@netlify/config` type, so the previously-suppressed error no longer occurs (TS2578). ## Scope notes - **#7701** (`@vitest/eslint-plugin` 1.3.20) was split out into its own PR (#8305) and is **no longer part of this branch**. - **#8288** (vitest 4) is intentionally excluded — it's blocked by an `@opentelemetry/api` peer conflict that fails install without `legacy-peer-deps`, and needs a separate decision. ## Verification Local (Node 24): `format:check`, `lint`, `typecheck` pass; **373/373 unit tests pass**. Integration/e2e not run locally (need auth token / network / Git LFS). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jaredm563 <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone replacement for #7701, applied directly on top of
main.Why not just merge #7701
#7701 (
renovate/vitest-eslint-plugin-1.x) was branched against an older tree pinned to vitest 3.2.4 and conflicts withmain. Merging it would downgrade vitest. This PR applies only its intent — the@vitest/eslint-plugin1.3.13 → 1.3.20bump — with no other version changes.Changes
@vitest/eslint-plugin→ 1.3.20. Its@typescript-eslint ^8.46.1dependency resolves as a nested subtree, so the top-leveltypescript-eslintstays at 8.45.0 andviteststays at 3.2.4.prefer-called-exactly-once-withrule; the 5 flagged assertions across 3 test files are collapsed intotoHaveBeenCalledExactlyOnceWith(...)(eslint--fix+ prettier).No
.npmrc/legacy-peer-depsneeded — this is purely on vitest 3.Verification
Local (Node 24):
lint,typecheck,format:checkpass; 373/373 unit tests pass. Integration/e2e not run locally (need auth token / network / Git LFS).Closes #7701.
🤖 Generated with Claude Code