Conversation
This was referenced Feb 18, 2022
f6106b3 to
a924e07
Compare
e6bd6c5 to
1842956
Compare
1 task
e6c59b2 to
190fa2f
Compare
92e8fa3 to
22daf38
Compare
781a13b to
3c57be1
Compare
Member
Author
|
Ok, I think this is done for review/testing Particular attention should be given to situations that change what mounts are available for a user (adding/removing shares/external storages/etc) and making sure file listings reflect these changes |
Signed-off-by: Robin Appelman <[email protected]>
26c2704 to
b065ea3
Compare
artonge
reviewed
Mar 24, 2022
PVince81
reviewed
Mar 24, 2022
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
d6f200b to
77f16f0
Compare
artonge
requested changes
Mar 24, 2022
artonge
reviewed
Mar 24, 2022
77f16f0 to
e818ac1
Compare
Co-authored-by: Louis <[email protected]> Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Robin Appelman <[email protected]>
e818ac1 to
881e107
Compare
artonge
approved these changes
Mar 24, 2022
Pytal
approved these changes
Mar 24, 2022
Member
|
@icewind1991 phpcs unhappy, can you fix ? |
Member
|
also s3 tests don't pass |
Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
Member
|
all necessary tests passed successfully in previous builds and my recent changes are not related to those the last commit was to satisfy "checkers" and that one passes now merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of always setting up the entire filesystem, it tries to only setup the bits needed for the path being accessed.
this is done by looking at the cached mounts in the
oc_mountstable to find the one matching for the path (and optionally also any mounts in subfolders), getting the mountpoints from these mounts and only setting up the mounts from those providers.Various systems are in place to try and ensure that this doesn't lead to an outdated setup if the mounts accessible to the user has changed