[stable8] fix(NcAppSidebarTab): Reduce pill height#8553
Merged
Conversation
Signed-off-by: kramo <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8553 +/- ##
========================================
Coverage 46.85% 46.85%
========================================
Files 195 195
Lines 4926 4926
Branches 1268 1205 -63
========================================
Hits 2308 2308
- Misses 2529 2531 +2
+ Partials 89 87 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShGKme
approved these changes
May 19, 2026
susnux
approved these changes
Jun 1, 2026
| left: 50%; | ||
| width: 0; | ||
| height: 6px; | ||
| height: 4px; |
Contributor
There was a problem hiding this comment.
Suggested change
| height: 4px; | |
| height: var(--default-grid-baseline); |
?
Member
Author
There was a problem hiding this comment.
No variable was used before, so I didn't. And I mean, you probably wouldn't want this scaling with that? It's closer to font weight, which is not derived from the baseline either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8547