Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[stable8] fix(NcAppSidebarTab): Reduce pill height #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Jun 1, 2026
Merged

[stable8] fix(NcAppSidebarTab): Reduce pill height #8553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/NcAppSidebar/NcAppSidebarTabs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ export default {
bottom: 0;
left: 50%;
width: 0;
height: 6px;
height: 4px;

@susnux susnux Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
height: 4px;
height: var(--default-grid-baseline);

?

@kra-mo kra-mo Jun 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No variable was used before, so I didn't. And I mean, you probably wouldn't want this scaling with that? It's closer to font weight, which is not derived from the baseline either.

border-radius: 999px;
background-color: var(--color-primary-element);
opacity: 0;
Expand Down
Loading