Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 31, 2023

Description

This PR introduces the missing rewrites that we've forgot to add before finishing the migration to Vercel. These were sourced from https://github.com/nodejs/build/blob/main/ansible/www-standalone/resources/config/nodejs.org?plain=1

Validation

Manual Testing that the Rewrites Work

Related Issues

Fixes #5578

@ovflowd ovflowd requested a review from a team as a code owner July 31, 2023 13:35
@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 2:16pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 2:16pm

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 31, 2023 13:35 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 31, 2023 13:36 Inactive
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Jul 31, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Jul 31, 2023

FYI requesting fast-tracking here! cc @nodejs/website as these rewrites are broken right now,

@vercel vercel bot temporarily deployed to Preview – nodejs-org July 31, 2023 13:50 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 31, 2023 13:51 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 31, 2023 14:00 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 31, 2023 14:00 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 31, 2023 14:08 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 31, 2023 14:09 Inactive
@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
92.42% (366/396) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 8.62s ⏱️

@nodejs nodejs deleted a comment from github-actions bot Jul 31, 2023
@nodejs nodejs deleted a comment from github-actions bot Jul 31, 2023
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 31, 2023 14:15 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 31, 2023 14:16 Inactive
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 140.83 KB (🟢 4.38 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 34.41 KB (🟢 -60 B) 175.24 KB
/[...path] 34.34 KB (🟢 -60 B) 175.17 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by undefined% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@ovflowd ovflowd merged commit 9f67d43 into main Jul 31, 2023
@ovflowd ovflowd deleted the feat/add-nginx-redirects branch July 31, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nodejs.org/calendar isn't redirecting to google calendar anymore

7 participants